Channel dropout Updated Seed QA#547
Closed
RooseweltMcW wants to merge 2 commits intor-abishek:ar/dropout_channelfrom
Closed
Channel dropout Updated Seed QA#547RooseweltMcW wants to merge 2 commits intor-abishek:ar/dropout_channelfrom
RooseweltMcW wants to merge 2 commits intor-abishek:ar/dropout_channelfrom
Conversation
… to the Kernel for randomization
| startCpuTime = clock(); | ||
| if (BitDepthTestMode == U8_TO_U8 || BitDepthTestMode == F16_TO_F16 || BitDepthTestMode == F32_TO_F32 || BitDepthTestMode == I8_TO_I8) | ||
| rppt_channel_dropout_host(input, srcDescPtr, output, dstDescPtr, dropoutProbability, randomSeed, roiTensorPtrSrc, roiTypeSrc, handle); | ||
| errorCodeCapture = rppt_channel_dropout_host(input, srcDescPtr, output, dstDescPtr, dropoutProbability, seed, roiTensorPtrSrc, roiTypeSrc, handle); |
Collaborator
There was a problem hiding this comment.
@RooseweltMcW errorCodeCapture changes won't be present in the PR currently and will result in CI failure . please remove error code capture for now in this PR
Srihari-mcw
requested changes
Dec 10, 2025
| * \retval RPP_ERROR* Unsuccessful completion. | ||
| */ | ||
| RppStatus rppt_channel_dropout_gpu(RppPtr_t srcPtr, RpptDescPtr srcDescPtr, RppPtr_t dstPtr, RpptDescPtr dstDescPtr, Rpp32f *dropoutProbability, bool randomSeed, RpptROIPtr roiTensorPtrSrc, RpptRoiType roiType, rppHandle_t rppHandle); | ||
| RppStatus rppt_channel_dropout_gpu(RppPtr_t srcPtr, RpptDescPtr srcDescPtr, RppPtr_t dstPtr, RpptDescPtr dstDescPtr, Rpp32f *dropoutProbability, Rpp32f seed, RpptROIPtr roiTensorPtrSrc, RpptRoiType roiType, rppHandle_t rppHandle); |
Collaborator
There was a problem hiding this comment.
Everywhere it must be Rpp32s instead of Rpp32f
Collaborator
|
these changes not required as we are completely moving out the mask computation |
ManasaDattaT
pushed a commit
to ManasaDattaT/rpp
that referenced
this pull request
Dec 19, 2025
) * Initial version for random channel permute for HOST * Implimented random channel permute for remaining bit depth on HOST * Initial concat implementation for HIp * Removed random channel permute implimentation and merged with swap channel * deleted random channel permute kernel * Golden output added for all variant of swap channel * Minor changes * Minor changes * Changed from simd to AVX * Small changes in comments * Optimized for pkd variant * Fix Build errors and QA tests * resolved review comments * Add F32 bin files and fix Pkd3-Pkd3 QA tests * Update CHANGELOG.md * Modified swap channels as channel permute and modified permutation tensor computation * minor changes * Update CHANGELOG.md * change permutation lists changes * updated comments for better readability * Update CHANGELOG.md * Change swap to permute --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Dineshbabu-Ravichandran <dineshbabu.ravichandran@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
RooseweltMcW
pushed a commit
to HazarathKumarM/rpp
that referenced
this pull request
Jan 21, 2026
) * Initial version for random channel permute for HOST * Implimented random channel permute for remaining bit depth on HOST * Initial concat implementation for HIp * Removed random channel permute implimentation and merged with swap channel * deleted random channel permute kernel * Golden output added for all variant of swap channel * Minor changes * Minor changes * Changed from simd to AVX * Small changes in comments * Optimized for pkd variant * Fix Build errors and QA tests * resolved review comments * Add F32 bin files and fix Pkd3-Pkd3 QA tests * Update CHANGELOG.md * Modified swap channels as channel permute and modified permutation tensor computation * minor changes * Update CHANGELOG.md * change permutation lists changes * updated comments for better readability * Update CHANGELOG.md * Change swap to permute --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Dineshbabu-Ravichandran <dineshbabu.ravichandran@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.