Common Typo Fix - Helper function rename#540
Merged
r-abishek merged 1 commit intor-abishek:ar/bugfix_minor_typofrom Dec 3, 2025
Merged
Common Typo Fix - Helper function rename#540r-abishek merged 1 commit intor-abishek:ar/bugfix_minor_typofrom
r-abishek merged 1 commit intor-abishek:ar/bugfix_minor_typofrom
Conversation
…_roi_conversion_ltrb_to_xywh
There was a problem hiding this comment.
Pull request overview
This PR corrects a spelling error in a function name throughout the codebase. The function hip_exec_roi_converison_ltrb_to_xywh has been renamed to hip_exec_roi_conversion_ltrb_to_xywh (fixing "converison" to "conversion").
Key Changes
- Renamed function from
hip_exec_roi_converison_ltrb_to_xywhtohip_exec_roi_conversion_ltrb_to_xywhin the function declaration and definition - Updated all function call sites across 54 files to use the corrected function name
Reviewed changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/include/common/hip/rpp_hip_roi_conversion.hpp | Updated function definition to use corrected spelling |
| src/include/batch_pd/hip/rpp_hip_host_decls.hpp | Updated function declaration to use corrected spelling |
| src/modules/tensor/hip/kernel/*.cpp (52 files) | Updated function calls to use corrected spelling |
Comments suppressed due to low confidence (1)
src/include/common/hip/rpp_hip_roi_conversion.hpp:32
- The kernel function name still contains the misspelling 'converison' and should be renamed to 'roi_conversion_ltrb_to_xywh' for consistency with the corrected wrapper function name.
static __global__ void roi_converison_ltrb_to_xywh(int *roiTensorPtrSrc)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Srihari-mcw
pushed a commit
to Srihari-mcw/rpp
that referenced
this pull request
Dec 8, 2025
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
ManasaDattaT
pushed a commit
to ManasaDattaT/rpp
that referenced
this pull request
Dec 19, 2025
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hip_exec_roi_converison_ltrb_to_xywhtohip_exec_roi_conversion_ltrb_to_xywh