RPP Unified External API for HOST and HIP#536
Merged
r-abishek merged 65 commits intor-abishek:ar/unified_apifrom Feb 11, 2026
Merged
RPP Unified External API for HOST and HIP#536r-abishek merged 65 commits intor-abishek:ar/unified_apifrom
r-abishek merged 65 commits intor-abishek:ar/unified_apifrom
Conversation
This was referenced Dec 2, 2025
Closed
856c677 to
3c57d3d
Compare
Srihari-mcw
pushed a commit
to Srihari-mcw/rpp
that referenced
this pull request
Dec 8, 2025
…e interpreted as links (r-abishek#536) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
ManasaDattaT
pushed a commit
to ManasaDattaT/rpp
that referenced
this pull request
Dec 19, 2025
…e interpreted as links (r-abishek#536) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
There was a problem hiding this comment.
Pull request overview
This pull request unifies the external API for RPP (ROCm Performance Primitives) by merging separate HOST and HIP (GPU) backend implementations into a single API with a runtime backend parameter. The changes enable users to specify the execution backend (HOST or HIP) when calling API functions, eliminating the need for separate function names for each backend.
Changes:
- Added backend tracking to the rppHandle structure to store whether a handle was created for HOST or HIP execution
- Unified API functions by adding an
executionBackendparameter to all tensor operations, replacing separate_hostand_gpusuffixed functions - Updated test suite calls across HOST and HIP test files to use the unified API with the appropriate backend parameter
Reviewed changes
Copilot reviewed 27 out of 32 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| utilities/test_suite/HOST/Tensor_voxel_host.cpp | Updated function calls to use unified API with RPP_HOST_BACKEND parameter |
| utilities/test_suite/HOST/Tensor_misc_host.cpp | Updated function calls to use unified API with RPP_HOST_BACKEND parameter |
| utilities/test_suite/HOST/Tensor_audio_host.cpp | Updated function calls to use unified API with RPP_HOST_BACKEND parameter |
| utilities/test_suite/HIP/Tensor_voxel_hip.cpp | Updated function calls to use unified API with RPP_HIP_BACKEND parameter |
| utilities/test_suite/HIP/Tensor_misc_hip.cpp | Updated function calls to use unified API with RPP_HIP_BACKEND parameter |
| utilities/test_suite/HIP/Tensor_audio_hip.cpp | Updated function calls to use unified API with RPP_HIP_BACKEND parameter |
| src/modules/tensor/rppt_tensor_morphological_operations.cpp | Merged _host/_gpu functions, added backend validation and layout checks |
| src/modules/tensor/rppt_tensor_filter_augmentations.cpp | Merged _host/_gpu functions, added backend validation and layout checks |
| src/modules/tensor/rppt_tensor_data_exchange_operations.cpp | Merged _host/_gpu functions, added backend validation |
| src/modules/tensor/rppt_tensor_bitwise_operations.cpp | Merged _host/_gpu functions, added backend validation and layout checks |
| src/modules/tensor/rppt_tensor_audio_augmentations.cpp | Merged _host/_gpu functions, added backend validation |
| src/modules/tensor/rppt_tensor_arithmetic_operations.cpp | Merged _host/_gpu functions, added backend validation |
| src/modules/handle_host.cpp | Added backend member initialization and GetBackend() method for HOST handle |
| src/modules/handle_hip.cpp | Added backend member initialization and GetBackend() method for HIP handle |
| src/include/common/handle.hpp | Added GetBackend() method declaration to handle interfaces |
| api/rppt_tensor_statistical_operations.h | Updated API documentation to reflect unified HOST/HIP functions |
| api/rppt_tensor_morphological_operations.h | Updated API documentation and function signatures |
| api/rppt_tensor_filter_augmentations.h | Updated API documentation and function signatures |
| api/rppt_tensor_data_exchange_operations.h | Updated API documentation and function signatures |
| api/rppt_tensor_bitwise_operations.h | Updated API documentation and function signatures |
| api/rppt_tensor_audio_augmentations.h | Updated API documentation and function signatures |
| api/rppt_tensor_arithmetic_operations.h | Updated API documentation and function signatures |
| api/rppdefs.h | Added RPP_ERROR_INCOMPATIBLE_BACKEND error code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
r-abishek
reviewed
Feb 11, 2026
r-abishek
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.