Address review comments for F16 Load/Store Updates#459
Merged
r-abishek merged 2 commits intor-abishek:ar/opt_f16_loads_stores_2from Jul 2, 2025
Merged
Conversation
ManasaDattaT
pushed a commit
to ManasaDattaT/rpp
that referenced
this pull request
Dec 19, 2025
* Add includes for half in rpp_defs
> Remove the Repeating half includes
* revert changes in old test suite
* Update rpp_test_suite_image.h to fix redefinition error
Error:
" In file included from /opt/rocm-6.3.0/share/rpp/test/HIP/Tensor_hip.cpp:33:
2989
4: /opt/rocm-6.3.0/share/rpp/test/HIP/../rpp_test_suite_image.h:53:14: error: typedef redefinition with different types ('half' (aka '__half') vs 'halfhpp' (aka 'half_float::half'))
2990
4: 53 | typedef half Rpp16f;
2991
4: | ^
2992
4: /opt/rocm/include/rpp/rppdefs.h:41:17: note: previous definition is here
2993
4: 41 | typedef halfhpp Rpp16f;
2994
4: | ^
2995
4: 1 error generated when compiling for gfx942."
---------
Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.