RPP Voxel Test suite fixes#458
Merged
r-abishek merged 1 commit intor-abishek:ar/test_suite_mods_12from Jul 2, 2025
Merged
Conversation
Collaborator
HazarathKumarM
commented
Jul 1, 2025
- fixed grouping
- fixed error return statements
There was a problem hiding this comment.
Pull Request Overview
This PR aims to correct grouping mappings for voxel tests and standardize error return codes.
- Introduced
voxelAugmentationGroupMapand modifiedfunc_group_finderto accept a generic group map argument. - Updated all calls to
process_layoutin HOST and HIP test runners to pass the appropriate group map. - Changed error returns in voxel host/hip binaries from
-1toRPP_ERROR_NOT_IMPLEMENTED.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| utilities/test_suite/common.py | Added voxelAugmentationGroupMap and updated func_group_finder. |
| utilities/test_suite/HOST/runVoxelTests.py | Removed inline finder, passing voxelAugmentationGroupMap to layout. |
| utilities/test_suite/HOST/runImageTests.py | Updated process_layout calls to use ImageAugmentationGroupMap. |
| utilities/test_suite/HOST/Tensor_voxel_host.cpp | Replaced return -1 with RPP_ERROR_NOT_IMPLEMENTED. |
| utilities/test_suite/HIP/runVoxelTests.py | Removed inline finder, passing voxelAugmentationGroupMap to layout. |
| utilities/test_suite/HIP/runImageTests.py | Updated process_layout calls to use ImageAugmentationGroupMap. |
| utilities/test_suite/HIP/Tensor_voxel_hip.cpp | Replaced return -1 with RPP_ERROR_NOT_IMPLEMENTED. |
Comments suppressed due to low confidence (1)
utilities/test_suite/HIP/runImageTests.py:353
- The variable
imageAugmentationMapis undefined in this context; it should beImageAugmentationGroupMapto match the imported mapping.
dstPathTemp, logFileLayout = process_layout(layout, qaMode, case, dstPath, "hip", imageAugmentationMap, func_group_finder)
ManasaDattaT
pushed a commit
to ManasaDattaT/rpp
that referenced
this pull request
Dec 19, 2025
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.