Changes to support legacy tests in MIVisionX by Srihari-mcw · Pull Request #429 · r-abishek/rpp

Srihari-mcw · 2025-05-02T12:29:56Z

Updates to support legacy tests in MIVisionX:

Reintroduction of typedef enum RppiChnFormat in rppdefs.h.
Include "rppi_legacy_augmentations.h" in "rppt.h" temporarily.
#ifdef LEGACY_SUPPORT flags in rppi_validate.hpp.
Creation of new folder src/include/legacy_dep and 2 hpp files added.
Creation of new folder src/modules/legacy_dep and 2 cpp files added.
CMakeLists changes for successful builds.

r-abishek

@Srihari-mcw Pls address comments

CMakeLists.txt

r-abishek · 2025-05-02T21:12:17Z

api/rppdefs.h

+typedef enum
+{
+    RPPI_CHN_PLANAR,
+    RPPI_CHN_PACKED


Can we not touch rppdefs.h and add this too into the same newly-created folder "legacy_dep", so the whole thing can be deleted later?

Hi @r-abishek ,

The RppiChnFormat structure is used across all kernels in legacy_dep folder, so it might not be possible to enclose it within one of the kernel.

One possible option is to introduce a separate common header file for legacy_dep folder and introduce it there - Might not be able to move the structure into existing imports because of the following reasons
The headers are isolated for hip and host and even in the common headers, the purpose of the headers (Eg - handle.hpp) seems to be different
Considering this I have kept it in the same file. Thanks - Pls do let me know if I need to make any changes further w.r.t this

api/rppi.h

src/modules/CMakeLists.txt

src/modules/legacy_dep/cpu/kernel/snow.cpp

src/modules/legacy_dep/cpu/kernel/hue.cpp

Srihari-mcw · 2025-05-07T14:56:50Z

Hi @r-abishek ,

The review comments were addressed. Thanks

Srihari-mcw · 2025-05-07T14:57:55Z

src/modules/legacy_dep/cpu/kernel/snow.cpp

+
+#include "host_legacy_executors.hpp"
+
+#define saturate_8u(value) ((value) > 255 ? 255 : ((value) < 0 ? 0 : (value)))


Have persisted with this change - saturate_8u because this is defined in similar way in other kernels as well in batch pd

r-abishek · 2025-05-12T18:51:34Z

Squash and merge to ensure easy revert if needed.

* Add updates to separate out Legacy Batch PD Support for RPP * Further changes to separate build for batchpd * Make changes to have add_kernels and add_kernel_includes only for Batch PD * Further changes to restore changes in hiperrors.cpp * Separate out batch pd code in rppi_validate.hpp * Update usage of RPP_LEGACY_SUPPORT * Add condition for OpenCL backend when Legacy Support is Disabled * More updates to CMakeLists.txt to selectively build based on RPP_LEGACY_SUPPORT * Changes to rppdefs.h * Remove whitespaces * Remove two more blank lines * Changes to enclose profiling functions and print function of handle inside RPP_LEGACY_SUPPORT * Additional cleanup * Remove empty line * Rename RpptPoint to RpptPoint2D * Rename files to handle_hip.cpp and handle_host.cpp * Move hiperrors content to errors.hpp * Remove hiperrors.cpp in CMakeLists.txt * Make hip error function inline * Add updates to Add RPP_LEGACY_SUPPORT flag to Batch PD Test Suite * Update minor version * Modify flag to LEGACY_SUPPORT * Add separate file for legacy support for RPP * Restore minor version * Changes to support legacy tests in MIVisionX (#429) Updates to support legacy tests in MIVisionX: - Reintroduction of typedef enum RppiChnFormat in rppdefs.h. - Include "rppi_legacy_augmentations.h" in "rppt.h" temporarily. - #ifdef LEGACY_SUPPORT flags in rppi_validate.hpp. - Creation of new folder src/include/legacy_dep and 2 hpp files added. - Creation of new folder src/modules/legacy_dep and 2 cpp files added. - CMakeLists changes for successful builds. Commits: * Add legacy_dep folder to add legacy code dependencies for MIVisionX * Add rppi_legacy_augmentations.h * Move files for include with src/include/legacy_dep * Make changes to fix issues with build * Add legacy support flag to rppi_validate.hpp * Add updates for hue and saturation * Fix issues for hue and saturation * Address review comments - 1 * Add licensing details and clear whitespace * Add comments to CMakeLists.txt * Add comments to CMakeLists.txt * Make updates to not support PLN variant for hue and saturation * Add additional comment * Updates to print message for LEGACY SUPPORT in CMake * Remove the additional setting of RPP_LEGACY_SUPPORT * Update RPP Version to 2.1.0 * Restore version to 2.0.0 * Remove empty line --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Srihari-mcw <96763064+Srihari-mcw@users.noreply.github.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>

…ek#548) * Add updates to separate out Legacy Batch PD Support for RPP * Further changes to separate build for batchpd * Make changes to have add_kernels and add_kernel_includes only for Batch PD * Further changes to restore changes in hiperrors.cpp * Separate out batch pd code in rppi_validate.hpp * Update usage of RPP_LEGACY_SUPPORT * Add condition for OpenCL backend when Legacy Support is Disabled * More updates to CMakeLists.txt to selectively build based on RPP_LEGACY_SUPPORT * Changes to rppdefs.h * Remove whitespaces * Remove two more blank lines * Changes to enclose profiling functions and print function of handle inside RPP_LEGACY_SUPPORT * Additional cleanup * Remove empty line * Rename RpptPoint to RpptPoint2D * Rename files to handle_hip.cpp and handle_host.cpp * Move hiperrors content to errors.hpp * Remove hiperrors.cpp in CMakeLists.txt * Make hip error function inline * Add updates to Add RPP_LEGACY_SUPPORT flag to Batch PD Test Suite * Update minor version * Modify flag to LEGACY_SUPPORT * Add separate file for legacy support for RPP * Restore minor version * Changes to support legacy tests in MIVisionX (r-abishek#429) Updates to support legacy tests in MIVisionX: - Reintroduction of typedef enum RppiChnFormat in rppdefs.h. - Include "rppi_legacy_augmentations.h" in "rppt.h" temporarily. - #ifdef LEGACY_SUPPORT flags in rppi_validate.hpp. - Creation of new folder src/include/legacy_dep and 2 hpp files added. - Creation of new folder src/modules/legacy_dep and 2 cpp files added. - CMakeLists changes for successful builds. Commits: * Add legacy_dep folder to add legacy code dependencies for MIVisionX * Add rppi_legacy_augmentations.h * Move files for include with src/include/legacy_dep * Make changes to fix issues with build * Add legacy support flag to rppi_validate.hpp * Add updates for hue and saturation * Fix issues for hue and saturation * Address review comments - 1 * Add licensing details and clear whitespace * Add comments to CMakeLists.txt * Add comments to CMakeLists.txt * Make updates to not support PLN variant for hue and saturation * Add additional comment * Updates to print message for LEGACY SUPPORT in CMake * Remove the additional setting of RPP_LEGACY_SUPPORT * Update RPP Version to 2.1.0 * Restore version to 2.0.0 * Remove empty line --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Srihari-mcw <96763064+Srihari-mcw@users.noreply.github.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>

Srihari-mcw added 4 commits May 2, 2025 16:45

Add legacy_dep folder to add legacy code dependencies for MIVisionX

1c91a26

Add rppi_legacy_augmentations.h

41bfd0c

Move files for include with src/include/legacy_dep

ad90df1

Make changes to fix issues with build

292cd80

Srihari-mcw changed the base branch from master to ar/legacy_support_flag May 2, 2025 12:30

Srihari-mcw added 3 commits May 2, 2025 21:45

Add legacy support flag to rppi_validate.hpp

4040c71

Add updates for hue and saturation

9002091

Fix issues for hue and saturation

fd4706a

r-abishek requested changes May 7, 2025

View reviewed changes

r-abishek assigned Srihari-mcw May 7, 2025

r-abishek added the enhancement New feature or request label May 7, 2025

Srihari-mcw added 6 commits May 7, 2025 12:05

Address review comments - 1

c985ad1

Add licensing details and clear whitespace

f43ef8b

Add comments to CMakeLists.txt

f9fa8b7

Add comments to CMakeLists.txt

7cdeeff

Make updates to not support PLN variant for hue and saturation

346fdd2

Add additional comment

01a0e2d

Srihari-mcw commented May 7, 2025

View reviewed changes

r-abishek changed the title ~~WIP : Changes to support legacy tests in MIVisionX~~ Changes to support legacy tests in MIVisionX May 12, 2025

r-abishek approved these changes May 12, 2025

View reviewed changes

r-abishek merged commit f50439e into r-abishek:ar/legacy_support_flag May 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes to support legacy tests in MIVisionX#429

Changes to support legacy tests in MIVisionX#429
r-abishek merged 13 commits intor-abishek:ar/legacy_support_flagfrom
Srihari-mcw:add_mivisionx_dependencies

Srihari-mcw commented May 2, 2025 •

edited by r-abishek

Loading

Uh oh!

r-abishek left a comment

Uh oh!

Uh oh!

r-abishek May 2, 2025

Uh oh!

Srihari-mcw May 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Srihari-mcw commented May 7, 2025

Uh oh!

Srihari-mcw May 7, 2025

Uh oh!

r-abishek commented May 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		#include "host_legacy_executors.hpp"

		#define saturate_8u(value) ((value) > 255 ? 255 : ((value) < 0 ? 0 : (value)))

Conversation

Srihari-mcw commented May 2, 2025 • edited by r-abishek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

r-abishek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

r-abishek May 2, 2025

Choose a reason for hiding this comment

Uh oh!

Srihari-mcw May 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Srihari-mcw commented May 7, 2025

Uh oh!

Srihari-mcw May 7, 2025

Choose a reason for hiding this comment

Uh oh!

r-abishek commented May 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Srihari-mcw commented May 2, 2025 •

edited by r-abishek

Loading