Merged
Conversation
See #6050, still keeping open to track NSIS changes
a878a95 to
c221053
Compare
Member
|
@The-Compiler can you give some guidance on what installer changes are required, if any? Just to change this conditional? (Maybe to turn it into this?) |
Member
Author
toofar
approved these changes
Aug 10, 2023
Member
toofar
left a comment
There was a problem hiding this comment.
Yup, merge away!
Sorry if it looked like I was passively aggressively blocking it by commenting without approving or disproving. I had just glanced at it then some-elses-problemed it.
I can see that the nsis installer defaults to x64 and you are removing the 32bit CI jobs, removing the now redundant x64 identifiers and any related conditionals.
LGTM
toofar
added a commit
that referenced
this pull request
Aug 12, 2023
We dropped 32bit support in #7804 and as a result removed the arch suffix from the binary that pyinstaller produces. This commit removes it form the lookup path in the installer too. Note that we are leaving the arch string in the installer itself for now. Mostly because it'll be removed as part of a later change when the installer itself is refreshed. But it might also be useful to clarify in the installer names what the arch is? Maybe, that reasoning might not fit with the previous change to remove the arch strings.
toofar
added a commit
that referenced
this pull request
Aug 12, 2023
We dropped 32bit support in #7804 and as a result removed the arch suffix from the binary that pyinstaller produces. This commit removes it form the lookup path in the installer too. Note that we are leaving the arch string in the installer itself for now. Mostly because it'll be removed as part of a later change when the installer itself is refreshed. But it might also be useful to clarify in the installer names what the arch is? Maybe, that reasoning might not fit with the previous change to remove the arch strings.
22 tasks
toofar
added a commit
that referenced
this pull request
Aug 13, 2023
We dropped 32bit support in #7804 and as a result removed the arch suffix from the binary that pyinstaller produces. This commit removes it form the lookup path in the installer too. Note that we are leaving the arch string in the installer itself for now. Mostly because it'll be removed as part of a later change when the installer itself is refreshed. But it might also be useful to clarify in the installer names what the arch is? Maybe, that reasoning might not fit with the previous change to remove the arch strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6050, still keeping that open to track NSIS changes