Test: Implement universal module setup/teardown#635
Merged
Conversation
Member
|
Just took a very quick look but seems good to me. |
Member
Author
There was a problem hiding this comment.
this translate object is temporary until we deprecate and remove QUnit.module's setup/teardown names for beforeEach/afterEach
5636dca to
1797086
Compare
Member
|
I didn't yet run this test, so something may be wrong, but it should work like this: QUnit.config.beforeEach = function( assert ) {
assert.deepEqual( Object.keys( this ), [ "helper" ] );
};
QUnit.module("context object", {
beforeEach: function( assert ) {
assert.deepEqual( Object.keys( this ), [ "helper" ] );
this.prop = "foobar";
},
helper: function() {}
});
QUnit.test("keys", function( assert ) {
assert.deepEqual( Object.keys( this ), [ "helper", "prop" ] );
});See also qunitjs/api.qunitjs.com#63 |
16ebe40 to
982063e
Compare
Member
There was a problem hiding this comment.
I'm okay with renaming these methods, but the "each" part doesn't really make sense, since they are called just once for each Test instance. We can also just leave the names as-is (Test#setup and Test#teardown), since these have a completely different scope. If we rename, then "before" and "after" should be good.
bc490e9 to
cf4321b
Compare
Member
Author
|
Rebased with suggested changes:
|
846b027 to
fa96fdf
Compare
QUnit.module setup and teardown functions are now deprecated as they were moved to beforeEach/afterEach. Tests were added to confirm they still work while deprecated. beforeEach and afterEach are no longer exposed to the test context as setup/teardown were accidentaly. Ref qunitjs#635
QUnit.module tests were moved - with some improvements - to a new test file modules.js Some other tests were also removed because they were revealed as unnecessary tests. Ref qunitjs#635
fa96fdf to
74d566f
Compare
Member
|
Looks good, let's land it. |
Member
|
Now we just need the API docs to land when we release 1.16. |
Member
|
Late to the party but just a note: I'm glad we chose "hooks" as that is consistent with Mocha's terminology. |
Member
Author
|
@JamesMGreene we checked on their documentation before choosing the name. |
This was referenced Sep 2, 2014
Member
|
\o/ |
leobalter
added a commit
to leobalter/api.qunitjs.com
that referenced
this pull request
Sep 11, 2014
leobalter
added a commit
to leobalter/api.qunitjs.com
that referenced
this pull request
Sep 11, 2014
jzaefferer
added a commit
to jzaefferer/qunit
that referenced
this pull request
Oct 10, 2014
Between locating the hooks in `QUnit` or `QUnit.config` and making them simple setters and callback lists (like QUnit.done et al) and upcoming plans for nested suites, we decided not to release this feature, for now. I'm keeping the abstractions for hooks in place, so it should be trivial to bring this back in whatever form we decide on later. Effectively reverts 5ee31a0 and follow-up commits. Fixes qunitjs#665 Ref qunitjs#633 Ref qunitjs#635 Ref qunitjs#647
jzaefferer
added a commit
to jzaefferer/qunit
that referenced
this pull request
Oct 17, 2014
Between locating the hooks in `QUnit` or `QUnit.config` and making them simple setters and callback lists (like QUnit.done et al) and upcoming plans for nested suites, we decided not to release this feature, for now. I'm keeping the abstractions for hooks in place, so it should be trivial to bring this back in whatever form we decide on later. Effectively reverts 5ee31a0 and follow-up commits. Fixes qunitjs#665 Ref qunitjs#633 Ref qunitjs#635 Ref qunitjs#647
leobalter
added a commit
to qunitjs/api.qunitjs.com
that referenced
this pull request
Dec 3, 2014
Deprecates setup/teardown. Ref qunitjs/qunit#635 Fixes #70 Closes #76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the equivalent of setup/teardown methods that are define once for the entire testsuite, but run for each test. To make this easier to understand, we've went from setup/teardown to beforeEach/afterEach, renaming the existing module properties at the same time (in a separate commit).
Fixes #633