Skip to content

code around ie issues for location#384

Closed
clog wants to merge 1 commit into
qunitjs:masterfrom
clog:bugfix
Closed

code around ie issues for location#384
clog wants to merge 1 commit into
qunitjs:masterfrom
clog:bugfix

Conversation

@clog

@clog clog commented Dec 25, 2012

Copy link
Copy Markdown
Contributor

Assigning incomplete url won't work for local files in ie7 and ie8. Means controls won't work when test page is opened locally.

controls won't work in ie7, ie8
Comment thread qunit/qunit.js

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry James M. Greene,

I didn't know force update removes comments associated with code segment. The
following is your original comment.

"That should definitely be window.location.host instead of
window.location.hostname. Also, I'm not sure if this works when using the
triple-slash short-form for File URIs on the localhost (i.e.
file://localhost/blah is equivalent to file:///blah) as I don't recall offhand
what the Location object will return for these properties when using the File
URI scheme...."

I just replaced hostname with host, you are right. :)

On the tripple-slash issue, I tried file:///* on Chrome, Firefox, IE7 and IE8.
They all work. I think it working. Maybe I don't understand your question?

@jzaefferer

Copy link
Copy Markdown
Member

Thanks, landed in 8676feb

@jzaefferer jzaefferer closed this Jan 3, 2013
@ghost ghost assigned jzaefferer Jan 3, 2013
leobalter pushed a commit to leobalter/qunit that referenced this pull request Mar 26, 2015
leobalter pushed a commit to leobalter/qunit that referenced this pull request Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants