Conversation
And add tests for verifying which files are and aren't reacted to, including coverage for the existing ignoring of events from "node_modules". This is prep for #1669.
…ories Previously the callback would return true for "cwd/node_modules", then return false for all its immediate sub directories, and also for all its indirect subdirectories. While these directories were eventually watched, it could sometimes take considerable time to iterate over these. Use node-watch's skip feature to improve on this. And while at it, move it up a level by ignoring the top-level node_modules as well, not merely paths that we happen to see somewhere within it. Do both just in case we don't see the top level for some reason.
Change `run.watch()` to also apply the `--require` file, so that we can observe any changes to `require.extensions`. Fixes #1669.
Krinkle
added a commit
that referenced
this pull request
Jan 18, 2025
These have been included by watch mode since QUnit 2.18, but so far only benefited you there if you manually passed these as individual files, or loaded them indirectly at runtime, or used your own glob that includes mjs and/or cjs. If you currently run qunit by passing a directory and have matching files that you want to skip, opt-out by passing `test/*.js` or `test/**/*.js` explicitly instead of `test/`. Follows-up #1676. Cherry-picked from 6f72eeb (3.0.0-dev). Cherry-picked from 53ee0a7 (3.0.0-dev).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.