Closed
Conversation
Fixes qunitjs#1084 Modularize and export load implementation The load impl remains as-is The QUnit.load entry point issues deprecation warning
Member
Author
|
This is severely outdated and there's been a lot of churn to merge back in. |
Krinkle
added a commit
to Krinkle/qunit
that referenced
this pull request
Oct 16, 2023
Based on qunitjs#1502 by @smcclure15. Closes qunitjs#1084. Co-authored-by: Steve <smcclure15@gmail.com>
Krinkle
added a commit
to Krinkle/qunit
that referenced
this pull request
Mar 2, 2024
Based on qunitjs#1502 by @smcclure15. Closes qunitjs#1084. Co-authored-by: Steve <smcclure15@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1084
Modularize and export load implementation
The load impl remains as-is
The QUnit.load entry point issues deprecation warning
There's more untangling we can do here among
start/config.autostart/load, but this will allow us to drop theQUnit.loadentry point in 3.0 while we are free to refactor internally.In the deprecation message, a recommended workflow can get a little complicated; it's not just "use
QUnit.startinstead", because there are some gotchas (can't call it more than once, etc). Given that this was never documented, I don't know that it's a must-have to suggest a replacement. Feedback welcomed