Build: Remove dependency on es2015-rollup preset#1027
Conversation
| babel( { | ||
| presets: [ "es2015-rollup" ] | ||
| presets: [ | ||
| [ "es2015", { modules: false } ] |
There was a problem hiding this comment.
I'm too lazy to search in the docs, what this modules mean?
There was a problem hiding this comment.
Modules = ES6-style modules vs scripts? Or something else? Link to docs please?
There was a problem hiding this comment.
This is basically telling Babel to not transpile ES modules, as they will be handled by rollup.
d3f932c to
930a9fe
Compare
It's still breaking on appveyor and travis. I'm starting to think it is a nice opportunity to try webpack. |
| "async": "1.5.2", | ||
| "babel-preset-es2015-rollup": "^1.1.1", | ||
| "babel-plugin-external-helpers": "6.8.0", | ||
| "browserstack-runner": "0.4.3", |
There was a problem hiding this comment.
missing a line with "babel-preset-es2015": "6.13.2",
There was a problem hiding this comment.
Yep. Forgot to --save-dev some of the npm installs.
930a9fe to
db7c3a3
Compare
Could be. I don't want to go through the hassle of reconfiguring things, but if someone else wants to, go for it. |
db7c3a3 to
5a1a2dd
Compare
|
@leobalter good to merge? Everything's green now. |
|
done! I'm really excited we finally have ES modules up. |
This is should fix the build by removing our dependency on the es2015-rollup preset.