add import attributes to the normalize function#1349
Merged
saghul merged 1 commit intoquickjs-ng:masterfrom Feb 13, 2026
Merged
add import attributes to the normalize function#1349saghul merged 1 commit intoquickjs-ng:masterfrom
saghul merged 1 commit intoquickjs-ng:masterfrom
Conversation
saghul
approved these changes
Feb 12, 2026
rkd77
pushed a commit
to rkd77/quickjs
that referenced
this pull request
Feb 13, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only module loading has access to import attributes, but according to the ES spec, import attributes are allowed to affect resolution as well. This PR adds
JSModuleNormalizeFunc2so you can provide a normalize function that takes import attributes.