Merged
Conversation
39dfb8a to
4422ec4
Compare
- Fix global variable names in Pan snippets - Use a similar dict structure to the good tests for the bad tests
- Test behaviour around negative numbers - Test all operators at least once
- Use _assert_lint_line consistently - Don't use variables where they aren't needed
- Use _assert_lint_line throughout
Member
Author
|
@wpoely86 would you be able to have a look at this? |
ned21
approved these changes
Jan 22, 2025
wpoely86
approved these changes
Jan 23, 2025
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #266.