panlint: Model messages as objects with a severity#266
Merged
jrha merged 2 commits intoquattor:mainfrom Dec 16, 2024
Merged
Conversation
d4a4d61 to
cafc7f7
Compare
Merged
eb21048 to
a40e36c
Compare
- Update tests to handle new message format - Drop severity of uppercase global variable check - Add test to check that message IDs have a consistent format and are unique - Fix _assert_lint_line docstring for messages being objects
a40e36c to
7437432
Compare
ned21
approved these changes
Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one part of the work that was done at RAL back in 2018 to allow tests to be
suppressed with magic comments, cherry-picked out into a manageable chunk.