Skip to content

Fix CI profile to let profile group control phase on prerelease site#1938

Merged
cderv merged 1 commit intomainfrom
fix/ci-prerelease-profile
Mar 5, 2026
Merged

Fix CI profile to let profile group control phase on prerelease site#1938
cderv merged 1 commit intomainfrom
fix/ci-prerelease-profile

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Mar 5, 2026

Follow-up to #1932. Reverts QUARTO_PROFILE from prerelease,prerelease-docs back to prerelease-docs in both CI workflows.

Why this is now safe

PR #1932 moved prerelease-subdomain out of the phase profiles (_quarto-prerelease.yml / _quarto-rc.yml) and into _quarto-prerelease-docs.yml. This means the profile group [rc, prerelease] order now correctly determines which phase branding appears on the prerelease site.

With #1932's explicit prerelease profile activation, the prerelease site was locked to "Pre-release" branding even during RC phase. Removing it lets the profile group default (set by the "flip to RC" commits) propagate correctly.

See discussion at:

What changes

File Before After
preview.yml:106 prerelease,prerelease-docs prerelease-docs
publish.yml:50 prerelease,prerelease-docs prerelease-docs
Scenario Active profiles Title
prerelease.quarto.org (dev phase) base + prerelease + prerelease-docs "Pre-release"
prerelease.quarto.org (RC phase) base + rc + prerelease-docs "Release Candidate"

Follow-up to #1932. Now that prerelease-subdomain is defined in
_quarto-prerelease-docs.yml rather than the phase profiles, the
profile group order correctly controls which phase is active on the
prerelease site. The explicit prerelease profile activation is no
longer needed and prevents RC branding from showing on
prerelease.quarto.org during RC phase.
@github-actions github-actions bot temporarily deployed to pull request March 5, 2026 10:14 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1938.quarto.org

@cderv cderv merged commit a34fdb6 into main Mar 5, 2026
4 checks passed
@cderv cderv deleted the fix/ci-prerelease-profile branch March 5, 2026 14:05
github-actions bot pushed a commit that referenced this pull request Mar 5, 2026
…1938)

Follow-up to #1932. Now that prerelease-subdomain is defined in
_quarto-prerelease-docs.yml rather than the phase profiles, the
profile group order correctly controls which phase is active on the
prerelease site. The explicit prerelease profile activation is no
longer needed and prevents RC branding from showing on
prerelease.quarto.org during RC phase.

(cherry picked from commit a34fdb6)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Successfully created backport PR for prerelease:

cderv added a commit that referenced this pull request Mar 5, 2026
…1938)

Follow-up to #1932. Now that prerelease-subdomain is defined in
_quarto-prerelease-docs.yml rather than the phase profiles, the
profile group order correctly controls which phase is active on the
prerelease site. The explicit prerelease profile activation is no
longer needed and prevents RC branding from showing on
prerelease.quarto.org during RC phase.

(cherry picked from commit a34fdb6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant