Skip to content

Avoid wildcard * import#46124

Merged
geoand merged 1 commit into
quarkusio:mainfrom
Pankraz76:avoid-star-imports-core
Feb 7, 2025
Merged

Avoid wildcard * import#46124
geoand merged 1 commit into
quarkusio:mainfrom
Pankraz76:avoid-star-imports-core

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Feb 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Apply coding guidelines for core extracting changes from: #45599

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Quarkus - Core 999-SNAPSHOT:
[INFO] 
[INFO] Quarkus - Development mode - SPI ................... SUCCESS [ 12.157 s]
[INFO] Quarkus - Core - Class Change Agent ................ SUCCESS [  0.507 s]
[INFO] Quarkus - IDE Launcher ............................. SUCCESS [ 24.398 s]
[INFO] Quarkus - Builder .................................. SUCCESS [  3.392 s]
[INFO] Quarkus - Core ..................................... SUCCESS [  0.077 s]
[INFO] Quarkus - Core - Extension Processor ............... SUCCESS [ 15.313 s]
[INFO] Quarkus - Core - Runtime ........................... SUCCESS [  4.226 s]
[INFO] Quarkus - Core - Deployment ........................ SUCCESS [ 26.040 s]
[INFO] Quarkus - JUnit 4 Mock ............................. SUCCESS [  0.228 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:30 min
[INFO] Finished at: 2025-02-07T10:05:32+01:00
[INFO] ------------------------------------------------------------------------
[INFO] 126 goals, 83 executed, 43 from cache, saving at least 11s
➜  core git:(avoid-star-imports-core)

@quarkus-bot quarkus-bot Bot added the area/core label Feb 6, 2025
@Pankraz76 Pankraz76 mentioned this pull request Feb 6, 2025
Closed
@Pankraz76 Pankraz76 marked this pull request as ready for review February 6, 2025 14:11
@Pankraz76

Pankraz76 commented Feb 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

works on my machine 👍 @geoand

@quarkus-bot

quarkus-bot Bot commented Feb 7, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9287986.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging/deployment

✖ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-6","-7","-8","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError
Details 
java.lang.AssertionError: 

Expecting actual:
  ["-6","-7","-8","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

✖ io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
Details 
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:799)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@geoand geoand merged commit e880f0a into quarkusio:main Feb 7, 2025
@quarkus-bot quarkus-bot Bot added this to the 3.19 - main milestone Feb 7, 2025
@Pankraz76 Pankraz76 changed the title Avoid wildcard * import Avoid wildcard * import Feb 7, 2025
@Pankraz76 Pankraz76 mentioned this pull request Feb 7, 2025
Closed
@Pankraz76 Pankraz76 mentioned this pull request Jun 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoand geoand geoand approved these changes

Assignees

No one assigned

Labels

area/core triage/flaky-test

Projects

None yet

Milestone

3.19.0.CR1

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @geoand