Skip to content

Avoid wildcard * import#45599

Closed
Pankraz76 wants to merge 0 commit into
quarkusio:mainfrom
Pankraz76:avoid-star-imports
Closed

Avoid wildcard * import#45599
Pankraz76 wants to merge 0 commit into
quarkusio:mainfrom
Pankraz76:avoid-star-imports

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Jan 14, 2025

Copy link
Copy Markdown

Avoid wildcard * import to obey coding guidelines

@Pankraz76 Pankraz76 marked this pull request as ready for review January 14, 2025 23:02
@Pankraz76

Copy link
Copy Markdown
Author

@geoand is this any good?

gastaldi
gastaldi previously approved these changes Jan 15, 2025

@gastaldi gastaldi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@quarkus-bot

This comment has been minimized.

@gastaldi gastaldi dismissed their stale review January 15, 2025 04:05

Please build locally before submitting PRs

@Pankraz76

Copy link
Copy Markdown
Author

yes sorry i will be more precisely in future

import io.quarkus.deployment.pkg.PackageConfig;
import io.quarkus.sbom.ApplicationManifestConfig;

import static io.quarkus.deployment.pkg.PackageConfig.JarConfig.JarType.MUTABLE_JAR;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change the import order in an inconsistent way... (hint: it's static empty-line java empty-line everything else)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally added the plugin. Thanks

@quarkus-bot quarkus-bot Bot added area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/funqy area/gradle Gradle area/graphql area/kafka area/kubernetes area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/smallrye area/testing area/tracing area/vertx labels Jan 15, 2025
import static io.restassured.RestAssured.given;
import static org.hamcrest.CoreMatchers.is;

import io.quarkus.test.common.QuarkusTestResource;

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although, I removed the remaining few with misaligned format, having 2 blanks after the package statement

after:

package org.acme;

import static io.restassured.RestAssured.given;

before:

package org.acme;


import static io.restassured.RestAssured.given;

@Pankraz76 Pankraz76 requested a review from rhusar January 15, 2025 18:49

@gsmet gsmet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed one remaining formatting issue but it should be good to go now.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 16, 2025
@Pankraz76

Copy link
Copy Markdown
Author

thanks 👍

@Pankraz76 Pankraz76 changed the title Avoid wildcard import Avoid wildcard * import Jan 16, 2025
@Pankraz76 Pankraz76 changed the title Avoid wildcard * import chore: Avoid wildcard * import Jan 16, 2025

@rhusar rhusar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

I honestly would just ban * imports altogether, like we do in some other projects. The next step could be setting up the rule in codestyle (and thus run in CI). But just my 5 cents.

@Pankraz76

Pankraz76 commented Jan 17, 2025

Copy link
Copy Markdown
Author

finally green 👍 is it mergeable yet, or is there a need for rebase?

@quarkus-bot

This comment has been minimized.

@Pankraz76

Copy link
Copy Markdown
Author

Thank you for the valuable lesson. Of course, I will adjust and try to discuss my topics before providing a demonstration of them. I'm more of a proactive person and like to take action. This needs to be done in a pleasant way. Sorry for being overwhelming.

@quarkus-bot

This comment has been minimized.

@Pankraz76

Copy link
Copy Markdown
Author

ready to merge this?

@quarkus-bot

This comment has been minimized.

@Pankraz76

Pankraz76 commented Jan 26, 2025

Copy link
Copy Markdown
Author

If the CI keeps failing, I would suggest splitting this PR into smaller parts, separated by modules, as this would better align with the separation of concerns principle. This is feedback I would have expected to receive initially. While this PR might seem trivial, it is still somewhat messy. Breaking it down module by module would make the changes clearer, easier to manage, and would simplify the process overall.

@Pankraz76 Pankraz76 changed the title chore: Avoid wildcard * import Avoid wildcard * import Jan 27, 2025
@Pankraz76 Pankraz76 requested a review from gastaldi January 27, 2025 20:27
@quarkus-bot

This comment has been minimized.

@gastaldi gastaldi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compilation error with this PR:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project quarkus-tck-microprofile-jwt: Compilation failure: Compilation failure:
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[15,13] cannot find symbol
[ERROR]   symbol:   class List
[ERROR]   location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[15,52] cannot find symbol
[ERROR]   symbol:   class ArrayList
[ERROR]   location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[19,13] cannot find symbol
[ERROR]   symbol:   class Enumeration
[ERROR]   location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[27,29] cannot find symbol
[ERROR]   symbol:   class Properties
[ERROR]   location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[27,48] cannot find symbol
[ERROR]   symbol:   class Properties
[ERROR]   location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[29,78] cannot find symbol
[ERROR]   symbol:   class HashMap
[ERROR]   location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider

@gastaldi

Copy link
Copy Markdown
Member

Fixed the changes and force-pushed, let's see if CI is happy now

@quarkus-bot

This comment has been minimized.

@Pankraz76

Copy link
Copy Markdown
Author

is it working now?

@quarkus-bot

This comment has been minimized.

@quarkus-bot

quarkus-bot Bot commented Jan 31, 2025

Copy link
Copy Markdown

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7b49de2.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 17 Build Failures Logs Raw logs 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍
Devtools Tests - JDK 17 Build Failures Logs Raw logs 🔍
Devtools Tests - JDK 21 Build Failures Logs Raw logs 🔍
Devtools Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍
Native Tests - Build tools and DevTools Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/opentelemetry/deployment integration-tests/container-image/maven-invoker-way 
! Skipped: extensions/liquibase-mongodb/deployment extensions/micrometer-opentelemetry/deployment extensions/micrometer-registry-prometheus/deployment and 60 more

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.logs.OtelLoggingFileTest.testLoggingData line 74 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2750)
	at java.base/java.util.Formatter.format(Formatter.java:2671)
	at java.base/java.util.Formatter.format(Formatter.java:2625)
	at java.base/java.lang.String.format(String.java:4145)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogFormatingData line 193 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2750)
	at java.base/java.util.Formatter.format(Formatter.java:2671)
	at java.base/java.util.Formatter.format(Formatter.java:2625)
	at java.base/java.lang.String.format(String.java:4145)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogParameterValue line 230 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2750)
	at java.base/java.util.Formatter.format(Formatter.java:2671)
	at java.base/java.util.Formatter.format(Formatter.java:2625)
	at java.base/java.lang.String.format(String.java:4145)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLoggingData line 93 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2750)
	at java.base/java.util.Formatter.format(Formatter.java:2671)
	at java.base/java.util.Formatter.format(Formatter.java:2625)
	at java.base/java.lang.String.format(String.java:4145)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testTrace line 132 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2750)
	at java.base/java.util.Formatter.format(Formatter.java:2671)
	at java.base/java.util.Formatter.format(Formatter.java:2625)
	at java.base/java.lang.String.format(String.java:4145)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

📦 integration-tests/container-image/maven-invoker-way

Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.9.0:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.

📦 integration-tests/container-image/maven-invoker-way/target/it/container-native-main

HelloWorldMainIT.testLaunchCommand(LaunchResult) - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: Exit code did not match ==> expected: <0> but was: <1>
	at io.quarkus.test.junit.QuarkusMainIntegrationTestExtension.beforeEach(QuarkusMainIntegrationTestExtension.java:62)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

HelloWorldMainIT.testLaunchCommand(LaunchResult) - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: Exit code did not match ==> expected: <0> but was: <1>
	at io.quarkus.test.junit.QuarkusMainIntegrationTestExtension.beforeEach(QuarkusMainIntegrationTestExtension.java:62)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

HelloWorldMainIT.testManualLaunch(QuarkusMainLauncher) - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at HelloWorldMainTest.testManualLaunch(HelloWorldMainTest.java:25)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusMainTestExtension.interceptTestMethod(QuarkusMainTestExtension.java:308)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

HelloWorldMainIT.testManualLaunch(QuarkusMainLauncher) - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at HelloWorldMainTest.testManualLaunch(HelloWorldMainTest.java:25)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusMainTestExtension.interceptTestMethod(QuarkusMainTestExtension.java:308)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

⚙️ JVM Tests - JDK 21 #

- Failing: extensions/opentelemetry/deployment integration-tests/container-image/maven-invoker-way 
! Skipped: extensions/liquibase-mongodb/deployment extensions/micrometer-opentelemetry/deployment extensions/micrometer-registry-prometheus/deployment and 60 more

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.logs.OtelLoggingFileTest.testLoggingData line 74 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2852)
	at java.base/java.util.Formatter.format(Formatter.java:2774)
	at java.base/java.util.Formatter.format(Formatter.java:2728)
	at java.base/java.lang.String.format(String.java:4390)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogFormatingData line 193 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2852)
	at java.base/java.util.Formatter.format(Formatter.java:2774)
	at java.base/java.util.Formatter.format(Formatter.java:2728)
	at java.base/java.lang.String.format(String.java:4390)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogParameterValue line 230 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2852)
	at java.base/java.util.Formatter.format(Formatter.java:2774)
	at java.base/java.util.Formatter.format(Formatter.java:2728)
	at java.base/java.lang.String.format(String.java:4390)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLoggingData line 93 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2852)
	at java.base/java.util.Formatter.format(Formatter.java:2774)
	at java.base/java.util.Formatter.format(Formatter.java:2728)
	at java.base/java.lang.String.format(String.java:4390)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testTrace line 132 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2852)
	at java.base/java.util.Formatter.format(Formatter.java:2774)
	at java.base/java.util.Formatter.format(Formatter.java:2728)
	at java.base/java.lang.String.format(String.java:4390)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

📦 integration-tests/container-image/maven-invoker-way

Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.9.0:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.

📦 integration-tests/container-image/maven-invoker-way/target/it/container-native-main

HelloWorldMainIT.testLaunchCommand(LaunchResult) - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: Exit code did not match ==> expected: <0> but was: <1>
	at io.quarkus.test.junit.QuarkusMainIntegrationTestExtension.beforeEach(QuarkusMainIntegrationTestExtension.java:62)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

HelloWorldMainIT.testLaunchCommand(LaunchResult) - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: Exit code did not match ==> expected: <0> but was: <1>
	at io.quarkus.test.junit.QuarkusMainIntegrationTestExtension.beforeEach(QuarkusMainIntegrationTestExtension.java:62)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

HelloWorldMainIT.testManualLaunch(QuarkusMainLauncher) - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at HelloWorldMainTest.testManualLaunch(HelloWorldMainTest.java:25)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.junit.QuarkusMainTestExtension.interceptTestMethod(QuarkusMainTestExtension.java:308)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

HelloWorldMainIT.testManualLaunch(QuarkusMainLauncher) - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at HelloWorldMainTest.testManualLaunch(HelloWorldMainTest.java:25)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.junit.QuarkusMainTestExtension.interceptTestMethod(QuarkusMainTestExtension.java:308)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/opentelemetry/deployment 
! Skipped: extensions/liquibase-mongodb/deployment extensions/micrometer-opentelemetry/deployment extensions/micrometer-registry-prometheus/deployment and 60 more

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.logs.OtelLoggingFileTest.testLoggingData line 74 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2750)
	at java.base/java.util.Formatter.format(Formatter.java:2671)
	at java.base/java.util.Formatter.format(Formatter.java:2625)
	at java.base/java.lang.String.format(String.java:4145)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogFormatingData line 193 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2750)
	at java.base/java.util.Formatter.format(Formatter.java:2671)
	at java.base/java.util.Formatter.format(Formatter.java:2625)
	at java.base/java.lang.String.format(String.java:4145)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogParameterValue line 230 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2750)
	at java.base/java.util.Formatter.format(Formatter.java:2671)
	at java.base/java.util.Formatter.format(Formatter.java:2625)
	at java.base/java.lang.String.format(String.java:4145)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLoggingData line 93 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2750)
	at java.base/java.util.Formatter.format(Formatter.java:2671)
	at java.base/java.util.Formatter.format(Formatter.java:2625)
	at java.base/java.lang.String.format(String.java:4145)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testTrace line 132 - History - More details - Source on GitHub

Details
java.util.UnknownFormatConversionException: Conversion = '{'
	at java.base/java.util.Formatter.parse(Formatter.java:2750)
	at java.base/java.util.Formatter.format(Formatter.java:2671)
	at java.base/java.util.Formatter.format(Formatter.java:2625)
	at java.base/java.lang.String.format(String.java:4145)
	at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
	at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
	at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)

⚙️ Devtools Tests - JDK 17 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP line 50 - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: 
[Run project return status should be zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP(ReactiveMessagingCodestartIT.java:50)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP line 50 - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: 
[Run project return status should be zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP(ReactiveMessagingCodestartIT.java:50)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka line 44 - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: 
[Run project return status should be zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka(ReactiveMessagingCodestartIT.java:44)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka line 44 - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: 
[Run project return status should be zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka(ReactiveMessagingCodestartIT.java:44)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target/quarkus-codestart-test/quarkus-messaging-amqp-6da12710-3158-4d93-8687-56058386f331/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
  /home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target/quarkus-codestart-test/quarkus-messaging-amqp-6da12710-3158-4d93-8687-56058386f331/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
  /home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target/quarkus-codestart-test/quarkus-messaging-kafka-1867e505-266b-43cf-a876-b8a3df74494f/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
  /home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target/quarkus-codestart-test/quarkus-messaging-kafka-1867e505-266b-43cf-a876-b8a3df74494f/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
  /home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

⚙️ Devtools Tests - JDK 21 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP line 50 - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: 
[Run project return status should be zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP(ReactiveMessagingCodestartIT.java:50)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP line 50 - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: 
[Run project return status should be zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP(ReactiveMessagingCodestartIT.java:50)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka line 44 - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: 
[Run project return status should be zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka(ReactiveMessagingCodestartIT.java:44)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka line 44 - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: 
[Run project return status should be zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka(ReactiveMessagingCodestartIT.java:44)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target/quarkus-codestart-test/quarkus-messaging-amqp-026abc9d-b54c-4162-a8cb-0e1877b3c3d2/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
  /home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target/quarkus-codestart-test/quarkus-messaging-amqp-026abc9d-b54c-4162-a8cb-0e1877b3c3d2/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
  /home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target/quarkus-codestart-test/quarkus-messaging-kafka-2cf90871-d857-4850-9f3b-0ba6e75691ad/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
  /home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target/quarkus-codestart-test/quarkus-messaging-kafka-2cf90871-d857-4850-9f3b-0ba6e75691ad/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
  /home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

⚙️ Devtools Tests - JDK 17 Windows #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target\quarkus-codestart-test\quarkus-messaging-amqp-003f838b-452e-429b-92b7-cd553b967f4a\mocked-data\java\src\main\java\ilove\quark\us\MyMessagingApplication.java
and path:
  D:\a\quarkus\quarkus\integration-tests\devtools\target\test-classes\__snapshots__\ReactiveMessagingCodestartIT\testAMQPContent\src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target\quarkus-codestart-test\quarkus-messaging-amqp-003f838b-452e-429b-92b7-cd553b967f4a\mocked-data\java\src\main\java\ilove\quark\us\MyMessagingApplication.java
and path:
  D:\a\quarkus\quarkus\integration-tests\devtools\target\test-classes\__snapshots__\ReactiveMessagingCodestartIT\testAMQPContent\src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target\quarkus-codestart-test\quarkus-messaging-kafka-78ef016b-4d49-4015-a1be-cf3695092523\mocked-data\java\src\main\java\ilove\quark\us\MyMessagingApplication.java
and path:
  D:\a\quarkus\quarkus\integration-tests\devtools\target\test-classes\__snapshots__\ReactiveMessagingCodestartIT\testKafkaContent\src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub

Details
java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java] 
Path:
  target\quarkus-codestart-test\quarkus-messaging-kafka-78ef016b-4d49-4015-a1be-cf3695092523\mocked-data\java\src\main\java\ilove\quark\us\MyMessagingApplication.java
and path:
  D:\a\quarkus\quarkus\integration-tests\devtools\target\test-classes\__snapshots__\ReactiveMessagingCodestartIT\testKafkaContent\src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:

⚙️ Native Tests - Build tools and DevTools #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.NativeAgentIT.testRunIntegrationTests line 27 - History - More details - Source on GitHub

Details
org.opentest4j.AssertionFailedError: 

expected: 0
 but was: 1
	at io.quarkus.maven.it.NativeAgentIT.testRunIntegrationTests(NativeAgentIT.java:27)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

📦 integration-tests/maven/target/test-classes/projects/native-agent-integration

org.acme.FruitsEndpointTest.testListAllFruits - History - More details - Source on GitHub

Details
java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor#launchDatabases threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=docker.io/postgres:17, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@3f49df49)
	at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.startDevDb(DevServicesDatasourceProcessor.java:369)
	at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.launchDatabases(DevServicesDatasourceProcessor.java:121)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.j...

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-6","-7","-8","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError
Details
java.lang.AssertionError: 

Expecting actual:
  ["-6","-7","-8","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)
  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
Details
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

@Pankraz76 Pankraz76 closed this Feb 6, 2025
@quarkus-bot quarkus-bot Bot added triage/invalid This doesn't seem right and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Feb 6, 2025
@Pankraz76

Copy link
Copy Markdown
Author

#46124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/funqy area/gradle Gradle area/graphql area/kafka area/kubernetes area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/smallrye area/testing area/tracing area/vertx triage/flaky-test triage/invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants