Avoid wildcard * import#45599
Conversation
|
@geoand is this any good? |
This comment has been minimized.
This comment has been minimized.
Please build locally before submitting PRs
|
yes sorry i will be more precisely in future |
| import io.quarkus.deployment.pkg.PackageConfig; | ||
| import io.quarkus.sbom.ApplicationManifestConfig; | ||
|
|
||
| import static io.quarkus.deployment.pkg.PackageConfig.JarConfig.JarType.MUTABLE_JAR; |
There was a problem hiding this comment.
Don't change the import order in an inconsistent way... (hint: it's static empty-line java empty-line everything else)
There was a problem hiding this comment.
finally added the plugin. Thanks
| import static io.restassured.RestAssured.given; | ||
| import static org.hamcrest.CoreMatchers.is; | ||
|
|
||
| import io.quarkus.test.common.QuarkusTestResource; |
There was a problem hiding this comment.
Although, I removed the remaining few with misaligned format, having 2 blanks after the package statement
after:
package org.acme;
import static io.restassured.RestAssured.given;
before:
package org.acme;
import static io.restassured.RestAssured.given;
gsmet
left a comment
There was a problem hiding this comment.
I fixed one remaining formatting issue but it should be good to go now.
|
thanks 👍 |
rhusar
left a comment
There was a problem hiding this comment.
Looks good now.
I honestly would just ban * imports altogether, like we do in some other projects. The next step could be setting up the rule in codestyle (and thus run in CI). But just my 5 cents.
|
finally green 👍 is it mergeable yet, or is there a need for rebase? |
This comment has been minimized.
This comment has been minimized.
|
Thank you for the valuable lesson. Of course, I will adjust and try to discuss my topics before providing a demonstration of them. I'm more of a proactive person and like to take action. This needs to be done in a pleasant way. Sorry for being overwhelming. |
This comment has been minimized.
This comment has been minimized.
|
ready to merge this? |
This comment has been minimized.
This comment has been minimized.
|
If the CI keeps failing, I would suggest splitting this PR into smaller parts, separated by modules, as this would better align with the separation of concerns principle. This is feedback I would have expected to receive initially. While this PR might seem trivial, it is still somewhat messy. Breaking it down module by module would make the changes clearer, easier to manage, and would simplify the process overall. |
This comment has been minimized.
This comment has been minimized.
gastaldi
left a comment
There was a problem hiding this comment.
Compilation error with this PR:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project quarkus-tck-microprofile-jwt: Compilation failure: Compilation failure:
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[15,13] cannot find symbol
[ERROR] symbol: class List
[ERROR] location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[15,52] cannot find symbol
[ERROR] symbol: class ArrayList
[ERROR] location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[19,13] cannot find symbol
[ERROR] symbol: class Enumeration
[ERROR] location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[27,29] cannot find symbol
[ERROR] symbol: class Properties
[ERROR] location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[27,48] cannot find symbol
[ERROR] symbol: class Properties
[ERROR] location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider
[ERROR] /Volumes/CaseSensitive/workspace/quarkus/tcks/microprofile-jwt/src/main/java/io/quarkus/tck/jwt/DeploymentPropertyConfigProvider.java:[29,78] cannot find symbol
[ERROR] symbol: class HashMap
[ERROR] location: class io.quarkus.tck.jwt.DeploymentPropertyConfigProvider
|
Fixed the changes and force-pushed, let's see if CI is happy now |
This comment has been minimized.
This comment has been minimized.
|
is it working now? |
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | JVM Tests - JDK 17 | Build |
Failures | Logs | Raw logs | 🔍 |
| ✖ | JVM Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
| ✖ | JVM Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🔍 |
| ✖ | Devtools Tests - JDK 17 | Build |
Failures | Logs | Raw logs | 🔍 |
| ✖ | Devtools Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
| ✖ | Devtools Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🔍 |
| ✖ | Native Tests - Build tools and DevTools | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 17 #
- Failing: extensions/opentelemetry/deployment integration-tests/container-image/maven-invoker-way
! Skipped: extensions/liquibase-mongodb/deployment extensions/micrometer-opentelemetry/deployment extensions/micrometer-registry-prometheus/deployment and 60 more📦 extensions/opentelemetry/deployment
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingFileTest.testLoggingData line 74 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2750)
at java.base/java.util.Formatter.format(Formatter.java:2671)
at java.base/java.util.Formatter.format(Formatter.java:2625)
at java.base/java.lang.String.format(String.java:4145)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogFormatingData line 193 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2750)
at java.base/java.util.Formatter.format(Formatter.java:2671)
at java.base/java.util.Formatter.format(Formatter.java:2625)
at java.base/java.lang.String.format(String.java:4145)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogParameterValue line 230 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2750)
at java.base/java.util.Formatter.format(Formatter.java:2671)
at java.base/java.util.Formatter.format(Formatter.java:2625)
at java.base/java.lang.String.format(String.java:4145)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLoggingData line 93 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2750)
at java.base/java.util.Formatter.format(Formatter.java:2671)
at java.base/java.util.Formatter.format(Formatter.java:2625)
at java.base/java.lang.String.format(String.java:4145)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testTrace line 132 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2750)
at java.base/java.util.Formatter.format(Formatter.java:2671)
at java.base/java.util.Formatter.format(Formatter.java:2625)
at java.base/java.lang.String.format(String.java:4145)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
📦 integration-tests/container-image/maven-invoker-way
✖ Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.9.0:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.
📦 integration-tests/container-image/maven-invoker-way/target/it/container-native-main
✖ HelloWorldMainIT.testLaunchCommand(LaunchResult) - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError: Exit code did not match ==> expected: <0> but was: <1>
at io.quarkus.test.junit.QuarkusMainIntegrationTestExtension.beforeEach(QuarkusMainIntegrationTestExtension.java:62)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
✖ HelloWorldMainIT.testLaunchCommand(LaunchResult) - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError: Exit code did not match ==> expected: <0> but was: <1>
at io.quarkus.test.junit.QuarkusMainIntegrationTestExtension.beforeEach(QuarkusMainIntegrationTestExtension.java:62)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
✖ HelloWorldMainIT.testManualLaunch(QuarkusMainLauncher) - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
at HelloWorldMainTest.testManualLaunch(HelloWorldMainTest.java:25)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.junit.QuarkusMainTestExtension.interceptTestMethod(QuarkusMainTestExtension.java:308)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
✖ HelloWorldMainIT.testManualLaunch(QuarkusMainLauncher) - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
at HelloWorldMainTest.testManualLaunch(HelloWorldMainTest.java:25)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.junit.QuarkusMainTestExtension.interceptTestMethod(QuarkusMainTestExtension.java:308)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
⚙️ JVM Tests - JDK 21 #
- Failing: extensions/opentelemetry/deployment integration-tests/container-image/maven-invoker-way
! Skipped: extensions/liquibase-mongodb/deployment extensions/micrometer-opentelemetry/deployment extensions/micrometer-registry-prometheus/deployment and 60 more📦 extensions/opentelemetry/deployment
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingFileTest.testLoggingData line 74 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2852)
at java.base/java.util.Formatter.format(Formatter.java:2774)
at java.base/java.util.Formatter.format(Formatter.java:2728)
at java.base/java.lang.String.format(String.java:4390)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogFormatingData line 193 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2852)
at java.base/java.util.Formatter.format(Formatter.java:2774)
at java.base/java.util.Formatter.format(Formatter.java:2728)
at java.base/java.lang.String.format(String.java:4390)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogParameterValue line 230 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2852)
at java.base/java.util.Formatter.format(Formatter.java:2774)
at java.base/java.util.Formatter.format(Formatter.java:2728)
at java.base/java.lang.String.format(String.java:4390)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLoggingData line 93 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2852)
at java.base/java.util.Formatter.format(Formatter.java:2774)
at java.base/java.util.Formatter.format(Formatter.java:2728)
at java.base/java.lang.String.format(String.java:4390)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testTrace line 132 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2852)
at java.base/java.util.Formatter.format(Formatter.java:2774)
at java.base/java.util.Formatter.format(Formatter.java:2728)
at java.base/java.lang.String.format(String.java:4390)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
📦 integration-tests/container-image/maven-invoker-way
✖ Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.9.0:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.
📦 integration-tests/container-image/maven-invoker-way/target/it/container-native-main
✖ HelloWorldMainIT.testLaunchCommand(LaunchResult) - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError: Exit code did not match ==> expected: <0> but was: <1>
at io.quarkus.test.junit.QuarkusMainIntegrationTestExtension.beforeEach(QuarkusMainIntegrationTestExtension.java:62)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
✖ HelloWorldMainIT.testLaunchCommand(LaunchResult) - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError: Exit code did not match ==> expected: <0> but was: <1>
at io.quarkus.test.junit.QuarkusMainIntegrationTestExtension.beforeEach(QuarkusMainIntegrationTestExtension.java:62)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
✖ HelloWorldMainIT.testManualLaunch(QuarkusMainLauncher) - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
at HelloWorldMainTest.testManualLaunch(HelloWorldMainTest.java:25)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at io.quarkus.test.junit.QuarkusMainTestExtension.interceptTestMethod(QuarkusMainTestExtension.java:308)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
✖ HelloWorldMainIT.testManualLaunch(QuarkusMainLauncher) - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
at HelloWorldMainTest.testManualLaunch(HelloWorldMainTest.java:25)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at io.quarkus.test.junit.QuarkusMainTestExtension.interceptTestMethod(QuarkusMainTestExtension.java:308)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
⚙️ JVM Tests - JDK 17 Windows #
- Failing: extensions/opentelemetry/deployment
! Skipped: extensions/liquibase-mongodb/deployment extensions/micrometer-opentelemetry/deployment extensions/micrometer-registry-prometheus/deployment and 60 more📦 extensions/opentelemetry/deployment
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingFileTest.testLoggingData line 74 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2750)
at java.base/java.util.Formatter.format(Formatter.java:2671)
at java.base/java.util.Formatter.format(Formatter.java:2625)
at java.base/java.lang.String.format(String.java:4145)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogFormatingData line 193 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2750)
at java.base/java.util.Formatter.format(Formatter.java:2671)
at java.base/java.util.Formatter.format(Formatter.java:2625)
at java.base/java.lang.String.format(String.java:4145)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLogParameterValue line 230 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2750)
at java.base/java.util.Formatter.format(Formatter.java:2671)
at java.base/java.util.Formatter.format(Formatter.java:2625)
at java.base/java.lang.String.format(String.java:4145)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testLoggingData line 93 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2750)
at java.base/java.util.Formatter.format(Formatter.java:2671)
at java.base/java.util.Formatter.format(Formatter.java:2625)
at java.base/java.lang.String.format(String.java:4145)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
✖ io.quarkus.opentelemetry.deployment.logs.OtelLoggingTest.testTrace line 132 - History - More details - Source on GitHub
Details
java.util.UnknownFormatConversionException: Conversion = '{'
at java.base/java.util.Formatter.parse(Formatter.java:2750)
at java.base/java.util.Formatter.format(Formatter.java:2671)
at java.base/java.util.Formatter.format(Formatter.java:2625)
at java.base/java.lang.String.format(String.java:4145)
at org.assertj.core.api.AbstractAssert.failure(AbstractAssert.java:177)
at org.assertj.core.api.AbstractAssert.failWithMessage(AbstractAssert.java:140)
at io.opentelemetry.sdk.testing.assertj.AttributesAssert.containsKey(AttributesAssert.java:166)
⚙️ Devtools Tests - JDK 17 #
- Failing: integration-tests/devtools
📦 integration-tests/devtools
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP line 50 - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError:
[Run project return status should be zero]
expected: 0
but was: 1
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP(ReactiveMessagingCodestartIT.java:50)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP line 50 - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError:
[Run project return status should be zero]
expected: 0
but was: 1
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP(ReactiveMessagingCodestartIT.java:50)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka line 44 - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError:
[Run project return status should be zero]
expected: 0
but was: 1
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka(ReactiveMessagingCodestartIT.java:44)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka line 44 - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError:
[Run project return status should be zero]
expected: 0
but was: 1
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka(ReactiveMessagingCodestartIT.java:44)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target/quarkus-codestart-test/quarkus-messaging-amqp-6da12710-3158-4d93-8687-56058386f331/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
/home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target/quarkus-codestart-test/quarkus-messaging-amqp-6da12710-3158-4d93-8687-56058386f331/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
/home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target/quarkus-codestart-test/quarkus-messaging-kafka-1867e505-266b-43cf-a876-b8a3df74494f/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
/home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target/quarkus-codestart-test/quarkus-messaging-kafka-1867e505-266b-43cf-a876-b8a3df74494f/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
/home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
⚙️ Devtools Tests - JDK 21 #
- Failing: integration-tests/devtools
📦 integration-tests/devtools
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP line 50 - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError:
[Run project return status should be zero]
expected: 0
but was: 1
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP(ReactiveMessagingCodestartIT.java:50)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP line 50 - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError:
[Run project return status should be zero]
expected: 0
but was: 1
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildAMQP(ReactiveMessagingCodestartIT.java:50)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka line 44 - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError:
[Run project return status should be zero]
expected: 0
but was: 1
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka(ReactiveMessagingCodestartIT.java:44)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka line 44 - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError:
[Run project return status should be zero]
expected: 0
but was: 1
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka(ReactiveMessagingCodestartIT.java:44)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target/quarkus-codestart-test/quarkus-messaging-amqp-026abc9d-b54c-4162-a8cb-0e1877b3c3d2/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
/home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target/quarkus-codestart-test/quarkus-messaging-amqp-026abc9d-b54c-4162-a8cb-0e1877b3c3d2/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
/home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target/quarkus-codestart-test/quarkus-messaging-kafka-2cf90871-d857-4850-9f3b-0ba6e75691ad/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
/home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target/quarkus-codestart-test/quarkus-messaging-kafka-2cf90871-d857-4850-9f3b-0ba6e75691ad/mocked-data/java/src/main/java/ilove/quark/us/MyMessagingApplication.java
and path:
/home/runner/work/quarkus/quarkus/integration-tests/devtools/target/test-classes/__snapshots__/ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
⚙️ Devtools Tests - JDK 17 Windows #
- Failing: integration-tests/devtools
📦 integration-tests/devtools
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target\quarkus-codestart-test\quarkus-messaging-amqp-003f838b-452e-429b-92b7-cd553b967f4a\mocked-data\java\src\main\java\ilove\quark\us\MyMessagingApplication.java
and path:
D:\a\quarkus\quarkus\integration-tests\devtools\target\test-classes\__snapshots__\ReactiveMessagingCodestartIT\testAMQPContent\src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testAMQPContent line 36 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testAMQPContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target\quarkus-codestart-test\quarkus-messaging-amqp-003f838b-452e-429b-92b7-cd553b967f4a\mocked-data\java\src\main\java\ilove\quark\us\MyMessagingApplication.java
and path:
D:\a\quarkus\quarkus\integration-tests\devtools\target\test-classes\__snapshots__\ReactiveMessagingCodestartIT\testAMQPContent\src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target\quarkus-codestart-test\quarkus-messaging-kafka-78ef016b-4d49-4015-a1be-cf3695092523\mocked-data\java\src\main\java\ilove\quark\us\MyMessagingApplication.java
and path:
D:\a\quarkus\quarkus\integration-tests\devtools\target\test-classes\__snapshots__\ReactiveMessagingCodestartIT\testKafkaContent\src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
✖ io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.testKafkaContent line 29 - History - More details - Source on GitHub
Details
java.lang.AssertionError:
[Snapshot is not matching (use -Dsnap to update it automatically): ReactiveMessagingCodestartIT/testKafkaContent/src_main_java_ilove_quark_us_MyMessagingApplication.java]
Path:
target\quarkus-codestart-test\quarkus-messaging-kafka-78ef016b-4d49-4015-a1be-cf3695092523\mocked-data\java\src\main\java\ilove\quark\us\MyMessagingApplication.java
and path:
D:\a\quarkus\quarkus\integration-tests\devtools\target\test-classes\__snapshots__\ReactiveMessagingCodestartIT\testKafkaContent\src_main_java_ilove_quark_us_MyMessagingApplication.java
do not have same content:
⚙️ Native Tests - Build tools and DevTools #
- Failing: integration-tests/maven
📦 integration-tests/maven
✖ io.quarkus.maven.it.NativeAgentIT.testRunIntegrationTests line 27 - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError:
expected: 0
but was: 1
at io.quarkus.maven.it.NativeAgentIT.testRunIntegrationTests(NativeAgentIT.java:27)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
📦 integration-tests/maven/target/test-classes/projects/native-agent-integration
✖ org.acme.FruitsEndpointTest.testListAllFruits - History - More details - Source on GitHub
Details
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor#launchDatabases threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=docker.io/postgres:17, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@3f49df49)
at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.startDevDb(DevServicesDatasourceProcessor.java:369)
at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.launchDatabases(DevServicesDatasourceProcessor.java:121)
at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.j...
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 extensions/smallrye-reactive-messaging/deployment
✖ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History
Expecting actual: ["-6","-7","-8","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"]-java.lang.AssertionError
Details
java.lang.AssertionError:
Expecting actual:
["-6","-7","-8","-10","-11","-12","-13","-14"]
to start with:
["-6", "-7", "-8", "-9"]
at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)
Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"]-java.lang.AssertionError
Details
java.lang.AssertionError:
Expecting actual:
["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
["-3", "-4", "-5", "-6"]
at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)
Avoid wildcard
*import to obey coding guidelines