Skip to content

Make files arg optional for complete#112

Merged
marschattha merged 1 commit into
mainfrom
ma/make_files_optional_for_complete
Jun 25, 2025
Merged

Make files arg optional for complete#112
marschattha merged 1 commit into
mainfrom
ma/make_files_optional_for_complete

Conversation

@marschattha

@marschattha marschattha commented Jun 24, 2025

Copy link
Copy Markdown
Member

Copilot AI review requested due to automatic review settings June 24, 2025 20:33
Copilot AI reviewed Jun 24, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@qltysh

qltysh Bot commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff.

Total Coverage: This PR will not change total coverage.

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@marschattha marschattha requested review from brynary and noahd1 June 24, 2025 20:33
noahd1
noahd1 approved these changes Jun 25, 2025
View reviewed changes

@noahd1 noahd1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems low risk considering that we're being more permissive not less.

Why specify a default value if not required? Seems like a default is most helpful in cases where a value is required.

@marschattha

marschattha commented Jun 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Why specify a default value if not required? Seems like a default is most helpful in cases where a value is required.

Mostly to keep following the existing convention (every param has a default value except total-parts-count) in this file, zod will turn it into null/undefined.

@marschattha marschattha merged commit b9133a4 into main Jun 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@noahd1 noahd1 noahd1 approved these changes
@brynary brynary Awaiting requested review from brynary

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marschattha @noahd1