Skip to content

Change 'files' parameter to only be required when command is publish#103

Merged
noahd1 merged 4 commits into
mainfrom
nd-files-arg
May 15, 2025
Merged

Change 'files' parameter to only be required when command is publish#103
noahd1 merged 4 commits into
mainfrom
nd-files-arg

Conversation

@noahd1

@noahd1 noahd1 commented May 13, 2025

Copy link
Copy Markdown
Member

Previously we only supported a single command (publish) which requires a files parameter. We now support 2 commands: publish and complete. "files" is an invalid parameter when the command is complete.

This makes 'files' an optional action parameter which then requires our code to provide its own validation of the files parameter based on the command.

Copilot AI review requested due to automatic review settings May 13, 2025 22:17
Copilot AI reviewed May 13, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@noahd1 noahd1 requested a review from brynary May 13, 2025 22:17
@qltysh

qltysh Bot commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Diff Coverage: The code coverage on the diff in this pull request is 80.0%.

Total Coverage: This PR will decrease coverage by 0.34%.

File Coverage Changes
Path File Coverage Δ Indirect
coverage/src/settings.ts -1.2
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh

qltysh Bot commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

All good ✅

@noahd1 noahd1 merged commit 8d5c844 into main May 15, 2025
7 checks passed
@marschattha

marschattha commented Jun 24, 2025

Copy link
Copy Markdown
Member

@noah shouldn't https://github.com/qltysh/qlty-action/blob/main/coverage/action.yml#L28 be changed as well?
This came up on discord https://discord.com/channels/1256822430505373696/1387046054804852818

@noahd1

noahd1 commented Jun 24, 2025

Copy link
Copy Markdown
Member Author

@marschattha Looks like you're right. We changed the code to require a parameter in the code, but still require it in the action definition. Wonder why it hasn't come up before for us?

@marschattha marschattha mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@brynary brynary brynary approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noahd1 @marschattha @brynary