B xzk remove chunked#112
Merged
longbai merged 3 commits intoqiniu:developfrom Jun 23, 2014
xuzhaokui:b_xzk_remove_chunked
Merged
B xzk remove chunked#112longbai merged 3 commits intoqiniu:developfrom xuzhaokui:b_xzk_remove_chunked
longbai merged 3 commits intoqiniu:developfrom
xuzhaokui:b_xzk_remove_chunked
Conversation
Contributor
There was a problem hiding this comment.
add Buffer check
func (*Buffer.Reader) Len
func (b *Buffer) Len() int
Len returns the number of bytes of the unread portion of the buffer; b.Len() == len(b.Bytes()).
Contributor
Author
There was a problem hiding this comment.
我觉得几个小分支没必要了，把文件的 Reader 搞定就可以解决主要矛盾了。
其实我们这么改的用途并不是想让客户继续用这个API，而且在 push 用户改的时候，会明确告诉它如果继续用这个 API 会造成本地的磁盘 IO。
另外，其实真正使用内存数据而非文件内容来上传的，应该是非常少的。
Contributor
|
LGTM |
There was a problem hiding this comment.
这里应该判extra.CheckCrc == 1 下面的 extra.CheckCrc = 2也不必要。
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
去除了 chunked 上传。
issue: http://pm.qbox.me/redmine/issues/9359