Add new param to retain more closed segments#93
Merged
Conversation
timvisee
reviewed
Jul 30, 2025
Member
timvisee
left a comment
There was a problem hiding this comment.
Please also add a test to assert the new behavior works
timvisee
reviewed
Jul 30, 2025
timvisee
reviewed
Jul 30, 2025
Member
Author
@timvisee already did the automated property tests that tests against 100 random values. I'm adding a normal test in #94. Will add |
9b89c83 to
be03389
Compare
25eb04f to
62431f5
Compare
timvisee
approved these changes
Aug 5, 2025
Member
timvisee
left a comment
There was a problem hiding this comment.
I've done quite a bit of testing on this one, all well and good. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever we are doing
prefix_truncate()in the wal, we can preserve more closed segments. The current value is 1 (implicit) and hence kept it as default for backwards compatibility.The advantage is that it can make it more likely to use wal delta transfer over streaming records which is faster than the latter.