Conversation
KShivendu
commented
Jul 30, 2025
src/lib.rs
Outdated
Comment on lines
+1136
to
+1139
| assert!(wal.entry(truncate_index).is_some()); | ||
| if truncate_index > 0 { | ||
| assert!(wal.entry(truncate_index - 1).is_none()); | ||
| } |
Member
Author
There was a problem hiding this comment.
@timvisee this is failing even without my changes. I thought when you call prefix_truncate it modifies the wal segment internally to trim early parts. But apparently, that's not the case. It seems to be leaving the entire segment that contains the entry as untouched. Is this expected behaviour? 🤔
I wrote this on basis of test_truncate() which comes just before this.
Member
There was a problem hiding this comment.
Yes, it keeps full segments. We cannot trim/truncate files on disk from the start.
timvisee
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only had a dedicated test for
truncate()but notprefix_truncate()While
prefix_truncate()only had an automated property test calledcheck_prefix_truncate()