Optimize HNSW plain-search filtered allocation#8175
Merged
Conversation
agourlay
commented
Feb 19, 2026
| hw_counter, | ||
| is_stopped, | ||
| ) | ||
| .collect() |
timvisee
approved these changes
Feb 19, 2026
JojiiOfficial
approved these changes
Feb 19, 2026
timvisee
pushed a commit
that referenced
this pull request
Feb 19, 2026
* Optimize HNSW plain-search filtered allocation * keep comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR propagates the filtered point iterator properly avoiding unnecessary allocations.
Issue found through profiling where gigantic
collect()calls shows up before scoring.The HNSW plain search uses
query_pointsto fetch the matching points from the payload index.This allocates the full filtered result set in memory which is then used for scoring.
However the underlying
search_plain_batchedrequires just an Iterator.I was not able to refactor
query_pointsto return an Iterator due to liftetime issues.Therefore so I simply inlined this tiny body for this call site.