Merged
Conversation
timvisee
approved these changes
Feb 17, 2026
Member
|
Great find. 3% of CPU time is insane. |
timvisee
pushed a commit
that referenced
this pull request
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
retrievefunction at the segment level is using internally a HashMap which is turned into a Vector as return type.However the most important caller rebuilds a HashMap from it right away.
This PR exposes the HashMap from the segment level and removes a large amount of unnecessary memory allocation.
Those back and forth conversions accounts for 3% of CPU time on the
search-*threads.