Skip to content

Ensure WAL and shard clocks consistency when creating shard snapshot#8104

Merged
ffuugoo merged 13 commits intodevfrom
shard-snapshot-clocks-consistency
Feb 13, 2026
Merged

Ensure WAL and shard clocks consistency when creating shard snapshot#8104
ffuugoo merged 13 commits intodevfrom
shard-snapshot-clocks-consistency

Conversation

@ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Feb 11, 2026

Hold WAL lock while archiving shard clocks, so that WAL and clocks are always consistent.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --workspace --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@coderabbitai

This comment was marked as resolved.

@ffuugoo ffuugoo force-pushed the shard-snapshot-clocks-consistency branch from 08bc3d9 to 59cec48 Compare February 11, 2026 14:30
@ffuugoo ffuugoo force-pushed the shard-snapshot-clocks-consistency branch from 59cec48 to bcfceab Compare February 11, 2026 17:55
coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@qdrant qdrant deleted a comment from coderabbitai bot Feb 12, 2026
@ffuugoo ffuugoo force-pushed the shard-snapshot-clocks-consistency branch from a006ecb to 4e7ec59 Compare February 12, 2026 10:15
@ffuugoo ffuugoo requested review from generall and timvisee February 12, 2026 10:16
@ffuugoo ffuugoo force-pushed the shard-snapshot-clocks-consistency branch from 0545252 to 62abd1d Compare February 13, 2026 08:53
@ffuugoo ffuugoo merged commit 05011e8 into dev Feb 13, 2026
15 checks passed
@ffuugoo ffuugoo deleted the shard-snapshot-clocks-consistency branch February 13, 2026 10:27
@timvisee timvisee mentioned this pull request Feb 17, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants