Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
reviewed
Feb 9, 2026
Member
timvisee
left a comment
There was a problem hiding this comment.
I agree the extra error handling isn't beautiful. But we cannot silently ignore thread join errors. Thanks!
timvisee
approved these changes
Feb 9, 2026
generall
pushed a commit
that referenced
this pull request
Feb 9, 2026
* Use spawn_blocking for segment locking * Wrap blocking task in AbortOnDropHandle * Use single blocking thread for fetching all segment size information --------- Co-authored-by: timvisee <tim@visee.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #8056
Uses spawn_blocking for the potentially blocking
segment.lock()operation which was discussed here #8056 (comment)