Skip to content

For snapshots directly restored, use default temp path in storage volume#8059

Merged
timvisee merged 1 commit intodevfrom
snapshot-restore-temp-path-to-storage
Feb 5, 2026
Merged

For snapshots directly restored, use default temp path in storage volume#8059
timvisee merged 1 commit intodevfrom
snapshot-restore-temp-path-to-storage

Conversation

@timvisee
Copy link
Member

@timvisee timvisee commented Feb 4, 2026

With #8025 we now stream unpacking on snapshot recovery.

This changes the default temporary directory for those actions from the snapshot directory to the storage directory.

In practice this means the snapshot is stored on the storage directory directly. This is significant for environments having a separate storage and snapshot volume, like our own cloud. Before a snapshot had to be moved across volumes to be promoted, which is very expensive. Now promotion is a simple directory rename making it super fast.

A minimal change to make the above behavior happen. We might do a more significant refactoring of how we configure and handle temporary files in the future.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@tellet-q tellet-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qdrant qdrant deleted a comment from coderabbitai bot Feb 5, 2026
@timvisee timvisee merged commit abb270f into dev Feb 5, 2026
15 checks passed
@timvisee timvisee deleted the snapshot-restore-temp-path-to-storage branch February 5, 2026 08:29
@timvisee timvisee mentioned this pull request Feb 17, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants