Attempt to Fix RST_STREAM by draining http2 channels#8019
Merged
Conversation
facc2e3 to
2653ce2
Compare
Member
|
currently, this PR doesn't fix |
Member
|
So far, I am only able to repro it on v1.16.3+ |
generall
approved these changes
Feb 5, 2026
timvisee
approved these changes
Feb 5, 2026
generall
added a commit
that referenced
this pull request
Feb 9, 2026
* Fix RST_STREAM by draining http2 channels * remove controversial duration time for now --------- Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix
Chasing HTTP2 frames with Wireshark while running search on a 3 nodes cluster.
Rational
I think our manual channel pool mechanism is dropping connection which are currently under use.
This PR introduces a draining mechanism to gracefully shutdown the channel.
Before
After