Hotfix: fix search aggregator error with limit 0#7972
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
generall
approved these changes
Jan 23, 2026
9 tasks
generall
pushed a commit
that referenced
this pull request
Feb 9, 2026
* Hotfix: fix search aggregator error with limit 0 * Don't handle points if limit is zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for #7967
It hits the unwrap here:
qdrant/lib/common/common/src/fixed_length_priority_queue.rs
Line 40 in e86d60e
I wasn't able to reproduce the exact issue reported by the user, but we clearly see a limit of 0 reached the search aggregator. There seem to be multiple ways to make this happen.
This applies a hotfix to accept a limit of 0, which will just collect no results.
In my opinion a better fix would be to propagate
NonZeroUsizeto more places, and to not process any queries with a limit of 0 at all. But it didn't seem very trivial to implement that so I'd like to give that a shot in a separate PR.We hit a similar issue before here: #7632
All Submissions:
devbranch. Did you create your branch fromdev?