lib/api/src/rest/schema.rs (1)

1378-1386: Update filter docs still imply inserts even for UpdateOnly.

Also applies to: 1417-1424

docs/redoc/master/openapi.json (1)

11168-11176: Consider making the default explicit in UpdateMode

Optional: add a default: "upsert" (and/or set a property default on update_mode) so generated clients and docs clearly reflect behavior when the field is omitted.

lib/api/src/grpc/proto/points.proto (1)

175-182: Clarify update_filter docs for update_mode semantics (still misleading).

The comment still states “New points will be inserted regardless of the filter,” which is false for UpdateOnly and misleading for InsertOnly. This duplicates a prior comment.

📝 Suggested doc tweak

-  // Filter to apply when updating existing points. Only points matching this filter will be updated.
-  // Points that don't match will keep their current state. New points will be inserted regardless of the filter.
+  // Filter to apply when updating existing points. Only points matching this filter will be updated.
+  // Points that don't match will keep their current state.
+  // New points are inserted only when update_mode is Upsert or InsertOnly;
+  // with UpdateOnly no inserts occur, and with InsertOnly this filter is ignored.

Also applies to: 1180-1184

lib/api/src/rest/schema.rs (1)

1378-1386: Clarify update_filter semantics when update_mode ≠ upsert.

The doc comment states "New points will be inserted regardless of the filter" which is misleading when update_mode is set to UpdateOnly (no inserts occur) or InsertOnly (no updates occur). Consider clarifying the interaction between these two fields.

tests/openapi/test_update_mode.py (1)

18-90: Tests look good, consider adding coverage for the default upsert mode.

The tests comprehensively verify update_only and insert_only semantics. For completeness, consider adding a test that verifies the default upsert mode (or explicit "update_mode": "upsert") both inserts new points and updates existing ones.

lib/shard/src/update.rs (1)

305-314: Minor: Consider optimizing point_ids.clone() in UpdateOnly branch.

The point_ids.clone() on line 308 allocates a new vector. Since both select_excluded_by_filter_ids and select_existing_points need the point IDs, consider whether one of these functions could accept a reference/slice instead to avoid the clone. However, this is a minor optimization and can be deferred.

lib/edge/python/src/update.rs (1)

41-68: Avoid unnecessary conditional path for default UpdateMode::Upsert when no condition is provided.

When callers pass UpdateMode::Upsert with no condition, the current code routes through UpsertPointsConditional with Filter::default(). Since Upsert is the default mode, this adds filter processing overhead without behavioral benefit. Consider routing to UpsertPoints directly:

♻️ Proposed adjustment

         let operation = match (condition, update_mode) {
             // If condition or non-default update_mode is provided, use conditional upsert
             (Some(condition), mode) => point_ops::PointOperations::UpsertPointsConditional(
                 point_ops::ConditionalInsertOperationInternal {
                     points_op: points,
                     condition: Filter::from(condition),
                     update_mode: mode,
                 },
             ),
+            (None, Some(UpdateMode::Upsert)) => point_ops::PointOperations::UpsertPoints(points),
             (None, Some(mode)) => point_ops::PointOperations::UpsertPointsConditional(
                 point_ops::ConditionalInsertOperationInternal {
                     points_op: points,
                     condition: Filter::default(),
                     update_mode: Some(mode),
                 },
             ),
             // Default case: regular upsert
             (None, None) => point_ops::PointOperations::UpsertPoints(points),
         };