Merged
Conversation
timvisee
requested changes
Dec 17, 2025
Member
timvisee
left a comment
There was a problem hiding this comment.
Good call to keep this version aware. I agree that removing the 1.9.0 logic is fine.
We need to adjust the transfer selection logic a little bit more, see below:
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
97f05d0 to
5c99631
Compare
ffuugoo
approved these changes
Dec 17, 2025
timvisee
added a commit
that referenced
this pull request
Dec 18, 2025
* easy fix with version check * Link to PR * Fix get transfers with source/target pairs, also fix dead replica aborts * Use new source/target functions elsewhere * Flip shard and peer arguments * Fix incorrect check, from should be to * Inline more format arguments --------- Co-authored-by: timvisee <tim@visee.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out to be trivial fix. The only non-trivial part is that we actually need to check version.
I am also removing version check for 1.9, as direct upgrade from <1.9 -> 1.16.3 should not be possible for many different reasons.