use urlencode to prevent breaking collection name with % in it#7759
Merged
use urlencode to prevent breaking collection name with % in it#7759
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
xzfc
approved these changes
Dec 13, 2025
Comment on lines
230
to
232
| shard_download_url.set_path(&format!( | ||
| "/collections/{collection_id}/shards/{shard_id}/snapshots/{}", | ||
| "/collections/{encoded_collection_name}/shards/{shard_id}/snapshots/{}", | ||
| &snapshot_description.name, |
Member
There was a problem hiding this comment.
Maybe do the same for snapshot_description.name?
timvisee
pushed a commit
that referenced
this pull request
Dec 18, 2025
* use urlencode to prevent breaking collection name with % in it * do the same for snapshot_description.name
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.