SegmentSearcher times out on lock contention#7755
Merged
Conversation
b002599 to
db2cb0a
Compare
db2cb0a to
19f42aa
Compare
agourlay
commented
Dec 17, 2025
| segment_query_context, | ||
| )?; | ||
|
|
||
| drop(read_segment); |
Member
Author
There was a problem hiding this comment.
small optimization as the read segment is not necessary to process the further results
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Dec 17, 2025
Member
Author
|
As discussed internally, I will follow up with a refactoring PR to use https://lskatz.github.io/fasten/parking_lot/struct.RwLock.html#method.try_read_until where possible to improve the tracking of the deadline during processing. |
timvisee
pushed a commit
that referenced
this pull request
Dec 18, 2025
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds timeout on the acquisition of the locks for segment_holder and individual segments for search operations.