Hotfix for Windows ARM64 builds, disable some Neon features#7690
Hotfix for Windows ARM64 builds, disable some Neon features#7690
Conversation
|
Merging this as temporary hotfix. This is confirmed to work in #7686 (comment). We can revert this temporary hotfix once #7691 is properly implemented. That will be done later. |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR adds Windows/MSVC compatibility to quantization code by introducing a preprocessor shim in C to handle the popcount operation, and systematically restricts Neon SIMD implementations across multiple Rust metric modules to non-Windows platforms. The C change maps Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes The changes follow a consistent, repetitive pattern across files with minimal logic density. Key areas to verify during review:
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* On Windows ARM64 builds, disable usage of neon * Also disable optimized popcount on Windows ARM64 * fix quantization build * revert changes in BQ --------- Co-authored-by: Ivan Pleshkov <pleshkov.ivan@gmail.com>
Hotfix for #7686
Some of these features don't work on Windows ARM64. This temporarily disabled them at compile time until we properly patch them.
Note: this is untested
All Submissions:
devbranch. Did you create your branch fromdev?