Fix shard clean up on snapshot restore without manifest#7673
Merged
Conversation
timvisee
commented
Dec 2, 2025
Comment on lines
+233
to
+238
| Some(shard) if snapshot_manifest.is_empty() => { | ||
| // Shard is no longer needed and can be dropped | ||
| shard.stop_gracefully().await; | ||
|
|
||
| None | ||
| } |
Member
Author
There was a problem hiding this comment.
Here's a branch where we also dropped shard (LocalShard). So we should gracefully stop.
generall
approved these changes
Dec 2, 2025
agourlay
approved these changes
Dec 2, 2025
timvisee
added a commit
that referenced
this pull request
Dec 3, 2025
* On local replica recovery, also gracefully stop shard without manifest * Reformat
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also gracefully stop local shard if we:
Should fix crasher run:
All Submissions:
devbranch. Did you create your branch fromdev?