Skip to content

Fix wiping of gridstore#7627

Merged
coszio merged 3 commits intodevfrom
fix-wiping-of-gridstore
Nov 27, 2025
Merged

Fix wiping of gridstore#7627
coszio merged 3 commits intodevfrom
fix-wiping-of-gridstore

Conversation

@coszio
Copy link
Contributor

@coszio coszio commented Nov 27, 2025

Related to #7624, #7621

This PR patches 2 more things:

  1. Makes sure we don't drop files while flushing, by waiting on bitmask guard to be released.
  2. Swaps usage of clear() which would recreate the storage, where wipe() was supposed to be used

@coszio coszio requested review from agourlay and timvisee November 27, 2025 13:53
coderabbitai[bot]

This comment was marked as resolved.

@qdrant qdrant deleted a comment from coderabbitai bot Nov 27, 2025
Copy link
Member

@agourlay agourlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@coszio coszio merged commit 6ca3e46 into dev Nov 27, 2025
15 checks passed
@coszio coszio deleted the fix-wiping-of-gridstore branch November 27, 2025 14:38
timvisee pushed a commit that referenced this pull request Dec 3, 2025
* fix wiping of gridstore

* clippy

* address @timvisee's review
@timvisee timvisee mentioned this pull request Dec 3, 2025
1 task
@timvisee timvisee mentioned this pull request Dec 5, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants