Skip to content

Add a user agent to HTTP clients#7623

Merged
timvisee merged 2 commits intodevfrom
add-user-agent
Nov 26, 2025
Merged

Add a user agent to HTTP clients#7623
timvisee merged 2 commits intodevfrom
add-user-agent

Conversation

@timvisee
Copy link
Member

@timvisee timvisee commented Nov 26, 2025

Similar to https://github.com/qdrant/cluster-manager/pull/391

Adds a user agent to all our internal HTTP clients sending out requests. This allows remotes to identify where requests are coming from.

A Qdrant peer requesting a snapshot from another peer now looks like this in logs:

2025-11-26T16:59:33.703884Z  INFO actix_web::middleware::logger: 127.0.0.1 "GET /collections/benchmark/shards/0/snapshot HTTP/1.1" 200 587776 "-" "Qdrant/1.16.2-dev" 0.008435

Note the user agent at the very end.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

coderabbitai[bot]

This comment was marked as resolved.

@qdrant qdrant deleted a comment from coderabbitai bot Nov 26, 2025
Copy link
Member

@KShivendu KShivendu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against all the places where we import and use reqwest. LGTM!

@timvisee
Copy link
Member Author

Verified against all the places where we import and use reqwest. LGTM!

Thanks!

@timvisee timvisee merged commit 6467931 into dev Nov 26, 2025
15 checks passed
@timvisee timvisee deleted the add-user-agent branch November 26, 2025 17:59
timvisee added a commit that referenced this pull request Dec 3, 2025
* Add user agent to add HTTP clients

* Move user agent constant to defaults.rs
@timvisee timvisee mentioned this pull request Dec 3, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants