Merged
Conversation
5dfa336 to
0fd92d0
Compare
0fd92d0 to
9c64592
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
107e720 to
e063af1
Compare
timvisee
approved these changes
Nov 27, 2025
Comment on lines
+57
to
+62
| // test that it timeouts if the segment_holder lock can't be acquired | ||
| let write_segment_holder_guard = shard.segments().write(); | ||
| let telemetry = shard | ||
| .get_telemetry_data(details, Duration::from_millis(10)) | ||
| .await; | ||
| assert!(matches!(telemetry, Err(CollectionError::Timeout { .. }))); |
timvisee
pushed a commit
that referenced
this pull request
Dec 3, 2025
* Improve timeout logic for Telemetry * assert! * fix misuses of StoppinGuard * decrease timeout for each shard
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #7579
get_optimization_statusto handle case with lower telemetry detailsStoppingGuardwhere it got moved into the task (e063af1)