Fix use the update runtime for update operations#7569
Merged
Conversation
timvisee
approved these changes
Nov 20, 2025
Member
timvisee
left a comment
There was a problem hiding this comment.
Lets take extra care with tokio::task::spawn in reviews. And maybe even ban (lint) it in the future.
FAILED tests/consensus_tests/test_collection_recovery_limits.py::test_collection_recovery_reach_limit - Exception: HTTP request to http://127.0.0.1:33891/collections/test_collection/points?wait=true&ordering=weak failed with status code 500 after 5.20299s with response body: {'status': {'error': 'Service internal error: task 240 panicked with message "A Tokio 1.x context was found, but IO is disabled. Call `enable_io` on the runtime builder to enable IO."'}, 'time': 3.28820663, 'usage': {'hardware': {'cpu': 0, 'payload_io_read': 0, 'payload_io_write': 70315, 'payload_index_io_read': 0, 'payload_index_io_write': 0, 'vector_io_read': 0, 'vector_io_write': 1649102}, 'inference': None}}
Member
Author
timvisee
reviewed
Nov 20, 2025
Comment on lines
32
to
+33
| .enable_time() | ||
| .enable_io() |
Member
There was a problem hiding this comment.
Let's just do enable_all() on all three runtimes. Wdyt?
timvisee
pushed a commit
that referenced
this pull request
Nov 25, 2025
* Fix use the update runtime for update operations * Enable IO on update runtime FAILED tests/consensus_tests/test_collection_recovery_limits.py::test_collection_recovery_reach_limit - Exception: HTTP request to http://127.0.0.1:33891/collections/test_collection/points?wait=true&ordering=weak failed with status code 500 after 5.20299s with response body: {'status': {'error': 'Service internal error: task 240 panicked with message "A Tokio 1.x context was found, but IO is disabled. Call `enable_io` on the runtime builder to enable IO."'}, 'time': 3.28820663, 'usage': {'hardware': {'cpu': 0, 'payload_io_read': 0, 'payload_io_write': 70315, 'payload_index_io_read': 0, 'payload_index_io_write': 0, 'vector_io_read': 0, 'vector_io_write': 1649102}, 'inference': None}}
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following update operations are running on the calling Tokio runtime:
For the REST API that would be the
actix-rtand for gRPC that would be thegeneralruntime.We actually have a dedicated runtime for update operations that we should be using instead.
https://github.com/qdrant/qdrant/blob/master/src/common/helpers.rs#L26-L45
This PR changes those 3 call sites to use it which should result in better stability in the other runtimes.
Sorry for the reformating noise.
Future work
There are more
tokio::task::spawnusages to audit to check their correctness.