Skip to content

Fix panic on startup with old storage, reenable old shard key format#7564

Merged
timvisee merged 2 commits intodevfrom
reenable-old-shard-key-format
Nov 19, 2025
Merged

Fix panic on startup with old storage, reenable old shard key format#7564
timvisee merged 2 commits intodevfrom
reenable-old-shard-key-format

Conversation

@timvisee
Copy link
Member

@timvisee timvisee commented Nov 19, 2025

Fixes #7559

Fixes a panic on startup if old storage is used. In Qdrant 1.15.0 to 1.15.3 we didn't migrate this properly.

This reenables support for the old format by reverting #7047 that removed it.

We can merge and release this in our next patch so that all storages will be migrated in Qdrant 1.16.1 and onward. In Qdrant 1.17.0 we can remove it again.

See #7559 (comment) for more details, including a reproducible example.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

coderabbitai[bot]

This comment was marked as resolved.

@qdrant qdrant deleted a comment from coderabbitai bot Nov 19, 2025
@agourlay
Copy link
Member

Thinking aloud.

It looks like we have a blind spot in the data storage compatibility tests.
I will check how to add coverage for the shard keys format there.

@timvisee
Copy link
Member Author

I will check how to add coverage for the shard keys format there.

That would be amazing!

@timvisee timvisee force-pushed the reenable-old-shard-key-format branch from 802c660 to d0798ff Compare November 19, 2025 10:16
coderabbitai[bot]

This comment was marked as resolved.

@qdrant qdrant deleted a comment from coderabbitai bot Nov 19, 2025
@timvisee timvisee merged commit 84b2fb8 into dev Nov 19, 2025
16 checks passed
@timvisee timvisee deleted the reenable-old-shard-key-format branch November 19, 2025 12:40
timvisee added a commit that referenced this pull request Nov 19, 2025
… format (#7564)"

This reverts commit 84b2fb8.

This reverts pull request <#7564>.
@timvisee
Copy link
Member Author

Opened a draft PR to re-remove this in Qdrant 1.17.0: #7565

timvisee added a commit that referenced this pull request Nov 25, 2025
…7564)

* Revert "Remove old shard key mapping format (#7047)"

This reverts commit 783c128.

This reverts pull request <#7047>.

* Bump TODOs
@timvisee timvisee mentioned this pull request Nov 25, 2025
timvisee added a commit that referenced this pull request Feb 11, 2026
… format (#7564)"

This reverts commit 84b2fb8.

This reverts pull request <#7564>.
timvisee added a commit that referenced this pull request Feb 11, 2026
… format (#7564)" (#7565)

This reverts commit 84b2fb8.

This reverts pull request <#7564>.
timvisee added a commit that referenced this pull request Feb 13, 2026
… format (#7564)" (#7565)

This reverts commit 84b2fb8.

This reverts pull request <#7564>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants