Merged
Conversation
timvisee
reviewed
Nov 18, 2025
| ))); | ||
| }; | ||
|
|
||
| if replica_set.is_proxy().await { |
Member
There was a problem hiding this comment.
I like that we use is_proxy() now, which is much more clear.
timvisee
approved these changes
Nov 18, 2025
Member
timvisee
left a comment
There was a problem hiding this comment.
I did not run (extensive) tests on this locally. I trust our CI and chaos testing for this one.
agourlay
approved these changes
Nov 18, 2025
timvisee
pushed a commit
that referenced
this pull request
Nov 25, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We observed the
Unwrapping proxy shardlog message shortly followed by consensus error in production.There are several problems with that:
Unwrapping proxy shardin case if the consensus is significantly delayed on receiver. It was checking for sahrd to be local, but didn't check if the relevant transfer status was received.Unwrapping proxy shard.Unwrapping proxy shardin the out-of-order operation is suspecious enough for this PRWhat this PR does:
Unwrapping proxy shardUnwrapping proxy shardis promoted to an error, as we should not see it anymore, assuming the logic is not compromised somewhere else.