Missing validations for shard transfers#7557
Merged
Conversation
agourlay
commented
Nov 18, 2025
| impl Validate for grpc::ReplicatePoints { | ||
| fn validate(&self) -> Result<(), ValidationErrors> { | ||
| Ok(()) | ||
| if self.from_shard_key != self.to_shard_key { |
Member
Author
There was a problem hiding this comment.
opportunistic change copying the validation logic from REST
Member
There was a problem hiding this comment.
Good change. This doesn't make sense between the same shard keys, because the points to replicate would already be there.
timvisee
approved these changes
Nov 18, 2025
timvisee
pushed a commit
that referenced
this pull request
Nov 25, 2025
* Missing validations for shard transfers * some more * fix test
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding missing validations for
RestartTransferforgRPCandRESTAPIs.