Conversation
|
@monoid please resolve merge conflicts |
Done. |
e0505f4 to
4dbfe82
Compare
What is exactly the benchmark setup here? Micro benchmark or end to end? |
It was a bfb benchmarks with 8-16 search threads and batch search. But it was an edge-case: full linear scan. |
|
For a more realistic example, |
`BatchFilteredScorer` is really a searcher (a search loop)
This reverts commit a136217.
Add `BatchSearch` struct instead of a tuple for `BatchFilteredSearcher`'s field.
4a84977 to
82842b6
Compare
timvisee
left a comment
There was a problem hiding this comment.
Everything seems handled. Thanks! 🙌
86f597d to
1bfb0f8
Compare
BatchFilteredScorer is the correct name.
1bfb0f8 to
6918419
Compare
IvanPleshkov
left a comment
There was a problem hiding this comment.
After this commit
6918419
the topic about deleted flags
#7514 (comment)
is still actual, we dont use deleted flag correctly in peek_top_all. Mark back as changes request
This commit is incorrect, I'm fixing it.
|
938eb0b to
60745bc
Compare
60745bc to
c566564
Compare
* Batched iteration for plain `HNSWIndex` searches * Batched iteration for `PlainVectorIndex` search
Previously each element of batch request was processed separately. This change handles them together in case of linear scans, exploiting memory caching to increase throughput by 2.8x.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: