Skip to content

Allow partial recovery of dummy shard#7512

Merged
timvisee merged 1 commit intodevfrom
partial-snapshot-dummy-shard-recovery
Nov 11, 2025
Merged

Allow partial recovery of dummy shard#7512
timvisee merged 1 commit intodevfrom
partial-snapshot-dummy-shard-recovery

Conversation

@ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Nov 11, 2025

This allows to recover "dummy" shards with partial snapshots.

This does zero additional validation, so it's easy to destroy the shard with an invalid/incompatible partial snapshot. But it should work as long as partial snapshot is "full".

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ffuugoo ffuugoo requested a review from timvisee November 11, 2025 10:34
@qdrant qdrant deleted a comment from coderabbitai bot Nov 11, 2025
@timvisee timvisee requested a review from tellet-q November 11, 2025 11:02
@timvisee
Copy link
Member

@timvisee timvisee merged commit 388f952 into dev Nov 11, 2025
20 of 21 checks passed
@timvisee timvisee deleted the partial-snapshot-dummy-shard-recovery branch November 11, 2025 11:44
timvisee pushed a commit that referenced this pull request Nov 14, 2025
@timvisee timvisee mentioned this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants