Conversation
Member
|
@JojiiOfficial please resolve the conflict |
331ad6d to
1d56493
Compare
generall
approved these changes
Nov 2, 2025
6 tasks
1d56493 to
6d22811
Compare
6d22811 to
3fe5ac1
Compare
timvisee
approved these changes
Dec 2, 2025
timvisee
pushed a commit
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qdrant panics if we create an empty
MetricFamily.I've run into this a few times since in some cases it requires a manual check that's easy to miss.
One example is #7478.
This PR improves the metrics collection logic to prevent such panics in the future.
It should help avoid most similar issues in future.