Access vector_data without risk of panicking#7469
Merged
Conversation
3 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
JojiiOfficial
approved these changes
Oct 29, 2025
ffuugoo
approved these changes
Oct 29, 2025
timvisee
added a commit
that referenced
this pull request
Nov 14, 2025
* Get vector data checked to prevent panic * Add invalid vector name error helper
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When accessing
vector_data, always use.get()rather than[]to not risk panicking.Semi-related: #7463 (comment)
All Submissions:
devbranch. Did you create your branch fromdev?