Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
5 tasks
timvisee
reviewed
Oct 28, 2025
Comment on lines
+42
to
+45
| /// Deprecation: this parameter is kept for preventing old keys to become valid after parameter removal. | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| #[deprecated(since = "1.15.0")] | ||
| #[validate(custom(function = "validate_payload_empty"))] |
Member
There was a problem hiding this comment.
Thanks! Came back to check exactly this, happy to see you implemented it this way!
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Oct 30, 2025
52a5fef to
b3fa1ba
Compare
timvisee
added a commit
that referenced
this pull request
Nov 14, 2025
* make jwt with payload filter fail * remove `whole` access requirement * remove unnecessary mut * fmt * adjust test * fix test * remove more tests * fix test * fix test again * fix test again * Replace deprecated PayloadConstraint with JSON Value placeholder * Fix expect message --------- Co-authored-by: timvisee <tim@visee.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Payload filter in JWT was deprecated in 1.15.0
This PR removes it