Skip to content

Metrics vectors by name per collection#7441

Merged
timvisee merged 7 commits intodevfrom
metrics-vectors-by-name-per-collection
Oct 29, 2025
Merged

Metrics vectors by name per collection#7441
timvisee merged 7 commits intodevfrom
metrics-vectors-by-name-per-collection

Conversation

@JojiiOfficial
Copy link
Contributor

@JojiiOfficial JojiiOfficial commented Oct 22, 2025 •
edited
Loading

Depends on #7310

This PR adds a new field in telemetry and metrics API, providing information about the vector count of each individual vector name.
Initially suggested here #7302 (comment)

New metric:

# HELP collection_name_vectors amount of vectors grouped by vector name
# TYPE collection_name_vectors gauge
collection_name_vectors{collection="test2",vector=""} 100
collection_name_vectors{collection="test",vector=""} 2
collection_name_vectors{collection="test",vector="text"} 1

New telemetry field:

"num_vectors_by_name": {"text":1 ,"" : 2}

@JojiiOfficial JojiiOfficial marked this pull request as draft October 22, 2025 16:08
@JojiiOfficial JojiiOfficial force-pushed the metrics-vectors-by-name-per-collection branch 2 times, most recently from e43f5d5 to 9af8de1 Compare October 23, 2025 09:43
@JojiiOfficial JojiiOfficial changed the title [WIP] Metrics vectors by name per collection Metrics vectors by name per collection Oct 24, 2025
@JojiiOfficial JojiiOfficial marked this pull request as ready for review October 24, 2025 10:33
@JojiiOfficial JojiiOfficial mentioned this pull request Oct 24, 2025
Merged
timvisee
timvisee approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, except for how we report it in metrics.

I suggest to replace the aggregation with the splitted entries: only show the vector count per named vector.

@JojiiOfficial JojiiOfficial force-pushed the metrics-vectors-by-name-per-collection branch from 0c32919 to 2a8c242 Compare October 29, 2025 14:25
Base automatically changed from metrics-dead-shards to dev October 29, 2025 15:48
@JojiiOfficial JojiiOfficial force-pushed the metrics-vectors-by-name-per-collection branch from 2a8c242 to 91e7ac3 Compare October 29, 2025 15:49
coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

@qdrant qdrant deleted a comment from coderabbitai bot Oct 29, 2025
@timvisee timvisee merged commit 48d61f1 into dev Oct 29, 2025
12 checks passed
@timvisee timvisee deleted the metrics-vectors-by-name-per-collection branch October 29, 2025 16:00
timvisee pushed a commit that referenced this pull request Nov 14, 2025
@JojiiOfficial @timvisee
Metrics vectors by name per collection (#7441)
df2b1c6 
* Add vector count per vector-name to metrics API

* Add to metrics API

* Improve TinyMap::get_or_insert_default and add tests

* Minor improvements

* Update openapi

* Review remarks

* Remove `collection_vectors` since it can be calculated manually
@timvisee timvisee mentioned this pull request Nov 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvisee timvisee timvisee approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@generall generall Awaiting requested review from generall

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JojiiOfficial @timvisee