Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
timvisee
approved these changes
Oct 21, 2025
| const WARN_INTERVAL_SECS: u64 = 10; | ||
|
|
||
| /// Last time a send warning was emitted (unix seconds) | ||
| static LAST_SEND_WARN: AtomicU64 = AtomicU64::new(0); |
Member
There was a problem hiding this comment.
Why not Instant::now() and last.elapse() > Duration::from_secs(10)?
Just to skip a lock, as we prefer not to lock at this stage?
Member
Author
There was a problem hiding this comment.
last.elapse() would need to have Instannt type, which is not atomic
timvisee
pushed a commit
that referenced
this pull request
Nov 14, 2025
* rate limit slow request warning queue * Update lib/collection/src/profiling/slow_requests_collector.rs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fmt --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't able to reproduce it even under 512 parallel search threads, but some users reported this message being spammy